GroupByEntityRule #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GureevLeonid
requested changes
Jul 9, 2024
Mindbox.Analyzers/MindboxAnalyzer.cs
Outdated
| @@ -35,7 +35,8 @@ static MindboxAnalyzer() | |||
| new ModelApplicationHostControllerServiceLocatorProhibitedRule(), | |||
| new NamedObjectModelConfigurationRegisterProhibitedRule(), | |||
| new DataContractRequireIfUsingDataMemberRule(), | |||
| new ForbidRawSqlOutsideDbProviderSpecificCodeRule() | |||
| new ForbidRawSqlOutsideDbProviderSpecificCodeRule(), | |||
| new GroupByEntityRule() | |||
There was a problem hiding this comment.
давай чуть имя правила улучшим
чтобы по нему было понятно, что правило энфорсит, как выше у других
| private const string Title = "Grouping by navigation property check"; | ||
| private const string MessageFormat = "Grouping by navigation properties is not allowed"; | ||
| private const string Description = | ||
| "Grouping by navigation properties is not allowed to avoid issues " + |
There was a problem hiding this comment.
в описании нужно описать как обойтись без навигационных свойств
щас предполагается - что разработчик пойдет смотреть ишью в npgsql, это кажется слишком долгим путем
нужно подсказать - что используй свойство такое-то взамен
GureevLeonid
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/mindbox-cloud/issues-platform/issues/2994