Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove old localization attr && move new one to Apstractions #105

Merged
merged 2 commits into from
Dec 10, 2024
Merged

remove old localization attr && move new one to Apstractions #105

merged 2 commits into from
Dec 10, 2024

Conversation

Runhard13
Copy link
Contributor

Задача FRMWK-682

Удалил старый атрибут + перенес новый в Abstractions + повысил версию библиотеки

gkurbesov
gkurbesov requested changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@gkurbesov gkurbesov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

У атрибута, который перенес, нужно неймспейс поправить

@Runhard13 Runhard13 requested a review from gkurbesov December 10, 2024 07:36
@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
Mindbox.I18n 36% 38% 102 ❌
Mindbox.I18n.Abstractions 63% 48% 80 ➖
Mindbox.I18n.Analyzers 61% 55% 153 ➖
Mindbox.I18n.AspNetCore 86% 94% 21 ✔
Mindbox.I18n.Template 49% 59% 46 ❌
Summary 55% (463 / 844) 53% (149 / 282) 402 ➖

@Runhard13 Runhard13 merged commit 187f116 into main Dec 10, 2024
1 check passed
@Runhard13 Runhard13 deleted the remove-old-localization-attr branch December 10, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkurbesov gkurbesov gkurbesov approved these changes

@gizdatullin gizdatullin Awaiting requested review from gizdatullin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Runhard13 @gkurbesov