Skip to content

Commit

Permalink
Fix singing -> signing typos where necessary (gravitational#45121)
Browse files Browse the repository at this point in the history
  • Loading branch information
webvictim authored Aug 6, 2024
1 parent 25d2a3e commit c8b1dc1
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion integrations/kube-agent-updater/hack/cosign-fixtures.go
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,7 @@ func generateSignedManifest(scenario string, signer digestedRefSigner, keys ...*
return
}

// Singing the manifest
// Signing the manifest
sigLayers, sigManifest, err := makeSignature(manifestRef, signer, keys...)
if err != nil {
return nil, nil, v1.Hash{}, trace.Wrap(err)
Expand Down
2 changes: 1 addition & 1 deletion integrations/kube-agent-updater/pkg/img/doc.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
// signed multiple times and this does not affect its digest.
// At the time of writing, cosign supports both static key signing and
// "keyless" (short-lived certificates) signing through the Fulcio CA.
// Keyless singing is still experimental and we don't use it yet, support might
// Keyless Signing is still experimental and we don't use it yet, support might
// be added in the future.
//
// The Cosign validator delegates all validation logic to the upstream cosign
Expand Down
2 changes: 1 addition & 1 deletion lib/auth/saml.go
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ func (a *Server) UpdateSAMLConnector(ctx context.Context, connector types.SAMLCo

// If someone is applying a SAML Connector obtained with `tctl get` without secrets, the signing key pair is
// not empty (cert is set) but the private key is missing. In this case we want to look up the existing SAML
// connector and populate the singing key from it if it's the same certificate. This avoids accidentally clearing
// connector and populate the signing key from it if it's the same certificate. This avoids accidentally clearing
// the private key and creating an unusable connector.
if connector.GetSigningKeyPair().PrivateKey == "" {
err := services.FillSAMLSigningKeyFromExisting(ctx, connector, a.Services)
Expand Down
2 changes: 1 addition & 1 deletion lib/services/saml.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ type SAMLConnectorGetter interface {
GetSAMLConnector(ctx context.Context, id string, withSecrets bool) (types.SAMLConnector, error)
}

const ErrMsgHowToFixMissingPrivateKey = "You must either specify the singing key pair (obtain the existing one with `tctl get saml --with-secrets`) or let Teleport generate a new one (remove singing_key_pair in the resource you're trying to create)."
const ErrMsgHowToFixMissingPrivateKey = "You must either specify the signing key pair (obtain the existing one with `tctl get saml --with-secrets`) or let Teleport generate a new one (remove signing_key_pair in the resource you're trying to create)."

// ValidateSAMLConnector validates the SAMLConnector and sets default values.
// If a remote to fetch roles is specified, roles will be validated to exist.
Expand Down
2 changes: 1 addition & 1 deletion lib/services/saml_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ func TestFillSAMLSigningKeyFromExisting(t *testing.T) {
assertResult require.ValueAssertionFunc
}{
{
name: "should read singing key from existing connector with matching cert",
name: "should read signing key from existing connector with matching cert",
connectorName: existingConnectorName,
connectorSpec: types.SAMLConnectorSpecV2{
SigningKeyPair: &types.AsymmetricKeyPair{
Expand Down

0 comments on commit c8b1dc1

Please sign in to comment.