refactor: fix code review comments

mindspore-lab · Dec 24, 2024 · b653af6 · b653af6
1 parent 686f322
commit b653af6
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 11 deletions.
diff --git a/llm/parallel/bert_imdb_finetune_dp/bert_imdb_finetune_npu_mindnlp_trainer.sh b/llm/parallel/bert_imdb_finetune_dp/bert_imdb_finetune_npu_mindnlp_trainer.sh
@@ -20,7 +20,6 @@ echo "start training"
 
 export MULTI_NPU="true" 
 export ASCEND_SLOG_PRINT_TO_STDOUT=1
-export ASCEND_RT_VISIBLE_DEVICES=6,7 # Specify the available card numbers
 
 msrun --worker_num=2 --local_worker_num=2 --master_port=8121 \
 --log_dir=bert_imdb_finetune_cpu_mindnlp_trainer_npus_same --join=True \

diff --git a/mindnlp/utils/download.py b/mindnlp/utils/download.py
@@ -147,11 +147,9 @@ def threads_exclusive_http_get(url, storage_folder=None, md5sum=None, download_f
     pointer_path = os.path.join(storage_folder, download_file_name)
     lock_file_path = pointer_path + ".lock"
     if sys.platform != "win32":
-# pylint: disable=import-error
-        import fcntl
+        import fcntl # pylint: disable=import-error
     else:
-# pylint: disable=import-error
-        import winfcntlock as fcntl
+        import winfcntlock as fcntl # pylint: disable=import-error
     with open(lock_file_path, 'w') as lock_file:
         fd = lock_file.fileno()
         try:

diff --git a/mindnlp/utils/winfcntlock.py b/mindnlp/utils/winfcntlock.py
@@ -13,12 +13,9 @@
 # limitations under the License.
 # ============================================================================
 """fcntl replacement for Windows."""
-# pylint: disable=import-error
-import win32con
-# pylint: disable=import-error
-import pywintypes
-# pylint: disable=import-error
-import win32file
+import win32con # pylint: disable=import-error
+import pywintypes # pylint: disable=import-error
+import win32file # pylint: disable=import-error
 
 
 LOCK_EX = win32con.LOCKFILE_EXCLUSIVE_LOCK