MineClonia redstone update support #694
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SmallJoker
reviewed
Dec 19, 2024
mesecons_gamecompat/init.lua
Outdated
| @@ -14,7 +14,7 @@ if minetest.get_modpath("default") then | |||
| dofile(minetest.get_modpath("mesecons_gamecompat").."/compat_mtg.lua") | |||
| end | |||
|
|
|||
| if minetest.get_modpath("mcl_core") then | |||
| if minetest.get_modpath("mcl_core") and minetest.get_modpath("mcl_trees") then | |||
There was a problem hiding this comment.
Why mcl_trees ? I don't see any such dependency.
There was a problem hiding this comment.
its because MineClonia and Voxelibre have mcl_core mod, so I put mcl_trees a mod exclusive from MineClonia, so it work not in Voxelibre.
There was a problem hiding this comment.
Are the used API functions of Voxelibre and MineClonia incompatible? Why can't we support both?
There was a problem hiding this comment.
Also has either Voxelibre or MCL considered adding a way to detect the fork?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently MineClonia has reworked the redstone mods
It adds support to