[New] SaveAs support empty sharedstring #405

mini-software · Jun 30, 2022 · 1de3020 · 1de3020
1 parent 7be1bca
commit 1de3020
Show file tree

Hide file tree

Showing 6 changed files with 29 additions and 1 deletion.
diff --git a/docs/README.md b/docs/README.md
@@ -22,6 +22,10 @@
 
 ---
 
+### 1.26.5
+- [New] Added DataReader AutoFilter toggle #402 #401 (via @Rollerss)
+- [New] SaveAs support empty sharedstring #405
+
 ### 1.26.4
 - [Bug] Using stream.SaveAs will close the Stream automatically when Specifying excelType
 - [OPT] Optimize Query big file  _IntMappingAlphabet.Count hot loading count (#400 via @CollapseNav)

diff --git a/docs/README.zh-CN.md b/docs/README.zh-CN.md
@@ -25,6 +25,10 @@
 
 ---
 
+### 1.26.5
+- [New] Added DataReader AutoFilter toggle #402 #401 (via @Rollerss)
+- [New] SaveAs 支持空白 sharedstring #405
+
 
 ### 1.26.4
 - [Bug] 使用Stream.SaveAs时指定excelType会自动关闭Stream #I57WMM

diff --git a/docs/README.zh-Hant.md b/docs/README.zh-Hant.md
@@ -24,6 +24,10 @@
 
 ---
 
+### 1.26.5
+- [New] Added DataReader AutoFilter toggle #402 #401 (via @Rollerss)
+- [New] SaveAs 支持空白 sharedstring #405
+
 ### 1.26.4
 - [Bug] 使用Stream.SaveAs時指定excelType會自動關閉Stream #I57WMM
 - [OPT] 減少在讀取大文件時 _IntMappingAlphabet.Count 的調用 (#400 via @CollapseNav)

diff --git a/src/MiniExcel/MiniExcelLibs.csproj b/src/MiniExcel/MiniExcelLibs.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 	<PropertyGroup>
 		<TargetFrameworks>net45;netstandard2.0;net5.0</TargetFrameworks>
-		<Version>1.26.4</Version>
+		<Version>1.26.5</Version>
 	</PropertyGroup>
 	<PropertyGroup>
 		<AssemblyName>MiniExcel</AssemblyName>

diff --git a/src/MiniExcel/OpenXml/ExcelOpenXmlSheetWriter.DefualtOpenXml.cs b/src/MiniExcel/OpenXml/ExcelOpenXmlSheetWriter.DefualtOpenXml.cs
@@ -182,11 +182,13 @@ static ExcelOpenXmlSheetWriter()
     {{format}}
 </Relationships>";
 
+        private static readonly string _defaultSharedString = "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\" ?><sst xmlns=\"http://schemas.openxmlformats.org/spreadsheetml/2006/main\" count=\"0\" uniqueCount=\"0\"></sst>";
         private static string MinifyXml(string xml) => xml.Replace("\r", "").Replace("\n", "").Replace("\t", "");
 
         internal void GenerateDefaultOpenXml()
         {
             CreateZipEntry("_rels/.rels", "application/vnd.openxmlformats-package.relationships+xml", ExcelOpenXmlSheetWriter._defaultRels);
+            CreateZipEntry("xl/sharedStrings.xml", "application/vnd.openxmlformats-package.relationships+xml", ExcelOpenXmlSheetWriter._defaultSharedString);
         }
 
         private void CreateZipEntry(string path,string contentType,string content)

diff --git a/tests/MiniExcelTests/MiniExcelIssueTests.cs b/tests/MiniExcelTests/MiniExcelIssueTests.cs
@@ -34,6 +34,20 @@ public MiniExcelIssueTests(ITestOutputHelper output)
             this.output = output;
         }
 
+        /// <summary>
+        /// [SaveAs Support empty sharedstring · Issue #405 · MiniExcel/MiniExcel]
+        /// (https://github.com/MiniExcel/MiniExcel/issues/405)
+        /// </summary>
+        [Fact]
+        public void TestIssue405()
+        {
+            var path = PathHelper.GetTempFilePath();
+            var value = new[] { new { id = 1, name = "test" } };
+            MiniExcel.SaveAs(path, value);
+
+            var xml = Helpers.GetZipFileContent(path, "xl/sharedStrings.xml");
+            Assert.StartsWith("<sst xmlns=\"http://schemas.openxmlformats.org/spreadsheetml/2006/main\"", xml);
+        }
 
         /// <summary>
         /// Using stream.SaveAs will close the Stream automatically when Specifying excelType