Populate Host header properly (#112)

Fixes #110 Signed-off-by: Bala.FA <[email protected]>
minio · Mar 6, 2024 · 4de2f19 · 4de2f19
1 parent ebb3c60
commit 4de2f19
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/baseclient.cc b/src/baseclient.cc
@@ -936,7 +936,8 @@ minio::s3::BaseClient::GetPresignedObjectUrl(GetPresignedObjectUrlArgs args) {
     utils::Time date = utils::Time::Now();
     if (args.request_time) date = args.request_time;
 
-    signer::PresignV4(args.method, url.host, url.path, region, query_params,
+    std::string host = url.HostHeaderValue();
+    signer::PresignV4(args.method, host, url.path, region, query_params,
                       creds.access_key, creds.secret_key, date,
                       args.expiry_seconds);
     url.query_string = query_params.ToQueryString();

diff --git a/src/request.cc b/src/request.cc
@@ -243,7 +243,7 @@ minio::s3::Request::Request(http::Method method, std::string region,
 
 void minio::s3::Request::BuildHeaders(http::Url& url,
                                       creds::Provider* provider) {
-  headers.Add("Host", url.host);
+  headers.Add("Host", url.HostHeaderValue());
   headers.Add("User-Agent", user_agent);
 
   bool md5sum_added = headers.Contains("Content-MD5");