Add MS Windows support #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balamurugana
requested changes
Feb 23, 2024
|
@balamurugana I now have the minio server running in my windows environment so I can successfully run |
* Disable spammy choco progress logging * Fix windows test bin bath
balamurugana
approved these changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should work with either MSVC or clang-cl. I've tested that the build and some example programs work on Ubuntu 22.04 and Windows 11 (both x64), but I can't run all the tests without a sever endpoint set and I don't have a Mac to test against, so there might still be some problems to fix after CI runs.
If the team is okay with moving forward with Windows support, I'd also be happy to add CI workflow steps for the build and tests and update the vcpkg port!