Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

minio / minio-cpp Public

Notifications You must be signed in to change notification settings
Fork 60
Star 154

Code
Issues 6
Pull requests 3
Actions
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Security
Insights

Rework entire code for correctness and potential bug fixes#111

Merged

balamurugana merged 83 commits intomainminio/minio-cpp:mainfrom feature/reworkminio/minio-cpp:feature/reworkCopy head branch name to clipboard

Mar 16, 2024

+2,466-1,727

Conversation Commits83 (83)Checks Files changed

Commits

Commits on Mar 13, 2024

Switched the cast to bool operators to explicit mode. The implicit ones are the root of all evil.
piotr-topnotch
committed
Implicit bool cast bug: added relational operators to Time
piotr-topnotch
committed
Implicit bool cast bug: error string building
piotr-topnotch
committed
Added explicit casts. Some code needs further inspection, as it makes no sense
piotr-topnotch
committed
Implicit bool cast bug: added error streaming operator
piotr-topnotch
committed
Improved const-correctness, defaulted the constructor and destructor
piotr-topnotch
committed
Const correctness and copy elimination
piotr-topnotch
committed
Improved const-correctness, defaulted the constructor and destructor, resolved the streaming bugs caused by the implicit bool conversion
piotr-topnotch
committed
Improved const-correctness, defaulted the constructor and destructor
piotr-topnotch
committed
Improved const-correctness, defaulted the constructors and destructors, explicit virtual ovverrides
piotr-topnotch
committed
De-inlining of complex functions
piotr-topnotch
committed
Const correctness + copy elision
piotr-topnotch
committed
Improved const-correctness, defaulted the constructors and destructors
piotr-topnotch
committed
COnst-correctness and copy elision
piotr-topnotch
committed
Const-correctness, copy elision, defaulting constructors and destructors
piotr-topnotch
committed
Const-correctness, copy elision, defaulting constructors and destructors
piotr-topnotch
committed
De-inlined complex functions
piotr-topnotch
committed
De-inlined complex functions
piotr-topnotch
committed
De-inlined complex functions, cleaned up includes
piotr-topnotch
committed
De-inlined complex functions, added <<() to Time
piotr-topnotch
committed
De-inlined complex functions
piotr-topnotch
committed
Bugfix: provided a default value
piotr-topnotch
committed
De-inlined complex functions, defaulted constructors and destructors, const correctness
piotr-topnotch
committed
De-inlined complex functions, defaulted constructors and destructors, const correctness
piotr-topnotch
committed
ebasing nullptr
piotr-topnotch
committed
Inlined the << operator
piotr-topnotch
committed
Conditionally enabled the spaceship operator
piotr-topnotch
committed
Implemented the basic version of Time::Compare
piotr-topnotch
committed
Enabled -Wall; follow-up fixes batch #1
piotr-topnotch
committed
Enabled -Wall; follow-up fixes batch #2
piotr-topnotch
committed
Const correctness, copy elision
piotr-topnotch
committed
Const reinforcement
piotr-topnotch
committed
Defaulted constructors and destructors, const correctness
piotr-topnotch
committed
Added explicit move construction support
piotr-topnotch
committed
Const hardening, copy elision
piotr-topnotch
committed
Copy elision
piotr-topnotch
committed
De-inlined complex functions, defaulted constructors and destructors, const correctness
piotr-topnotch
committed
Initialization improvements, defaulted destructors
piotr-topnotch
committed
Initialization improvements
piotr-topnotch
committed
Restored Windows compatibility
piotr-topnotch
committed
rvalue references are not needed for arithmetic types
piotr-topnotch
committed
The default copy constructor is fine
piotr-topnotch
committed
Added -Wall -Wextra
piotr-topnotch
committed
Added default initializaters, as they are skipped at the call sites
piotr-topnotch
committed
Unused parameter
piotr-topnotch
committed
Added default initializaters, as they are skipped at the call sites
piotr-topnotch
committed
De-inlined virtual functions, defaulted constructors and destructors
piotr-topnotch
committed
Added default initializaters, as they are skipped at the call sites
piotr-topnotch
committed
ebasingization improvements, defaulted destructors
piotr-topnotch
committed
-Wextra fixes
piotr-topnotch
committed
-Wconversion fixes
piotr-topnotch
committed
Bugfix: broken copy construction
piotr-topnotch
committed
Switched to default copy constructor and assignment operator
piotr-topnotch
committed
Assignment optimization
piotr-topnotch
committed
Bugfix: ToLower
piotr-topnotch
committed
Removed a couple of PWTODOs
piotr-topnotch
committed
ebasingfixes
piotr-topnotch
committed
Replaced h with result_headers, fixed the ifs lacking braces
piotr-topnotch
committed
Linter
piotr-topnotch
committed
Namet member initialization is a C++20 feature
piotr-topnotch
committed
Removed a class of resolved comments
piotr-topnotch
committed
Removed a class of resolved comments #2
piotr-topnotch
committed
Bugfix: resp is always false in the else branch
piotr-topnotch
committed
Windows warning fixes, part #1
piotr-topnotch
committed
Fixed MSVC warnings
piotr-topnotch
committed
Fixed MSVC warnings
piotr-topnotch
committed
Fixed MSVC warnings
piotr-topnotch
committed
Fixed MSVC warnings
piotr-topnotch
committed
Muted the Windows headers-related warnings
piotr-topnotch
committed
Bugfix: narrowing conversion
piotr-topnotch
committed
throw() is deprecated
piotr-topnotch
committed
function-try-block make sure no exception passes unnoticed
piotr-topnotch
committed
Use throw; for rethrowing exceptions
piotr-topnotch
committed
Linter
piotr-topnotch
committed
Linter
piotr-topnotch
committed
Linter
piotr-topnotch
committed

Commits on Mar 14, 2024

Resolved the Time::operator << issue
piotr-topnotch
committed
Resolved the UTC flag issue: Bala wants to remove it
piotr-topnotch
committed
Removed the PWTODO comments
piotr-topnotch
committed
Linter
piotr-topnotch
committed

Commits on Mar 15, 2024

Replaced main() with args with just main(), as it is a legal C++ signature
piotr-topnotch
committed
Aligned the return types
piotr-topnotch
committed
Linter
piotr-topnotch
committed

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.