Reworked CMakeLists.txt #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kobalicek
commented
Mar 19, 2024
kobalicek
commented
- Moved the logic into a single CMakeLists.txt file
- Added miniocpp:: namespace and thus miniocpp::miniocpp target
- Removed the generation of header files (config.h.in)
- Consolidated tests and examples - use MINIO_CPP_TEST to build them all
- Use miniocpp::miniocpp target in tests and exampels to simplify the use of dependencies
- Setup the cmake project with DESCRIPTION and VERSION
- Use GNUInstallDirs when installing targets
- Export cmake files so another cmake can find minio-cpp by using find_package(miniocpp) and then use miniocpp::miniocpp
- Building both documentation and tests/examples is OFF by default
kobalicek
force-pushed
the
cmake_update
branch
5 times, most recently
from
e8b4871 to
1c48cb3
Compare
* Moved the logic into a single CMakeLists.txt file
* Added miniocpp:: namespace and thus miniocpp::miniocpp target
* Removed the generation of header files (config.h.in)
* Consolidated tests and examples - use MINIO_CPP_TEST to build
them all
* Use miniocpp::miniocpp target in tests and exampels to simplify
the use of dependencies
* Setup the cmake project with DESCRIPTION and VERSION
* Use GNUInstallDirs when installing targets
* Export cmake files so another cmake can find minio-cpp by
using find_package(miniocpp) and then use miniocpp::miniocpp
* Building both documentation and tests/examples is OFF by default
balamurugana
approved these changes
Mar 20, 2024
harshavardhana
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.