Allow custom (non-propagating) stateful set metadata #2337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramondeklein
force-pushed
the
custom-sts-metadata
branch
from
11361b4 to
3d1425c
Compare
shtripat
previously approved these changes
Oct 15, 2024
pkg/client/applyconfiguration/minio.min.io/v2/statefulsetmetadata.go
Outdated
Show resolved
Hide resolved
pkg/client/applyconfiguration/minio.min.io/v2/statefulsetmetadata.go
Outdated
Show resolved
Hide resolved
ramondeklein
force-pushed
the
custom-sts-metadata
branch
from
f7b31a8 to
77fad77
Compare
shtripat
reviewed
Oct 16, 2024
ramondeklein
force-pushed
the
custom-sts-metadata
branch
from
83172e1 to
77fad77
Compare
|
@ramondeklein could you please take a look at the failing tests. |
ramondeklein
force-pushed
the
custom-sts-metadata
branch
2 times, most recently
from
20780cb to
e66492a
Compare
ramondeklein
force-pushed
the
custom-sts-metadata
branch
2 times, most recently
from
eb5c1e6 to
9cab4fe
Compare
ramondeklein
force-pushed
the
custom-sts-metadata
branch
from
9cab4fe to
fe4a452
Compare
|
@cesnietor Done... |
cesnietor
approved these changes
Oct 17, 2024
pjuarezd
approved these changes
Oct 17, 2024
|
Any chance a new release could be cut to catch this change? Thanks! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2318. This PR will remove all automatic propagation of metadata from the
Tenantresource to the child resources (statefulset, pod, service, pvc)..spec.poolsMetadata.Annotations/.spec.poolsMetadata.Labels. Per-pool labels/annotations can be set using.spec.pools[].Annotationsor.spec.pools[].Labels..spec.serviceMetadata. There are custom options for MinIO, console and KES.PersistentVolumeClaimobject.Breaking change
Note that this may be a breaking change for some deployments that depend on propagating annotations/labels from the tenant to downstream resources.