Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check if cookies are iterable before iterating #356

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

das-peter
Copy link

It can happen that the returned value is not iterable. The geetAllCookies() methode also declares the its return as "mixed".
Just about having slightly more defensive code.

It can happen that the returned value is not iterable. The geetAllCookies() methode also declares the its return as "mixed".
@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #356 (f387514) into master (e5f8421) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #356      +/-   ##
============================================
+ Coverage     90.02%   90.04%   +0.02%     
- Complexity      150      151       +1     
============================================
  Files             1        1              
  Lines           421      422       +1     
============================================
+ Hits            379      380       +1     
  Misses           42       42              
Impacted Files Coverage Δ
src/Selenium2Driver.php 90.04% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5f8421...f387514. Read the comment docs.

@stof
Copy link
Member

stof commented Apr 28, 2022

In which case does this happen ?

@das-peter
Copy link
Author

I had a request to wd/hub/session/chrome-100-0-4896-75-1-bc5dc535-0653-4f64-814c-d172db4c1582/session/bed6779a89bb52104cef11e83d40d7e6/cookie return null as value.
Underlying library is instaclick/php-webdriver - \WebDriver\Session::getAllCookies() which just passes the value as received from the endpoint back to the consumer.
It is highly likely this is / was an error on the endpoint but I don't think this warrants a generic failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants