Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syn.js v0.15.0 input event must be fired synchronously #364

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented May 1, 2023

based on bitovi/syn#196, fixes bitovi/syn#120

input event must be synchronous per spec - https://w3c.github.io/uievents/#event-type-input

repro case: bitovi/syn#120 (comment)

@codecov
Copy link

codecov bot commented May 1, 2023

Codecov Report

Merging #364 (ecca1c7) into master (affb7ea) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #364   +/-   ##
=========================================
  Coverage     90.62%   90.62%           
  Complexity      150      150           
=========================================
  Files             1        1           
  Lines           448      448           
=========================================
  Hits            406      406           
  Misses           42       42           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mvorisek mvorisek changed the title Fix syn.js v0.15.0 input event to be synchronous Fix syn.js v0.15.0 input event must be fired synchronously May 1, 2023
@mvorisek mvorisek marked this pull request as ready for review May 3, 2023 14:54
@aik099
Copy link
Member

aik099 commented May 4, 2023

@mvorisek , do I understand correctly, that you're proposing the Syn library change to Mink, which isn't yet merged into the Syn library itself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"input" event should fire synchronously when input field value changes
2 participants