Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strictSSL support #152

Closed
wants to merge 1 commit into from
Closed

Conversation

robballou
Copy link

Supporting the strictSSL option for Zombie allows developers to turn off strict certificate tests that stop self-signed/development certificates in some cases.

I still need to figure out how this would be passed in from outside mink itself (from behat for example).

@aik099
Copy link
Member

aik099 commented Jan 26, 2016

Are you sure this works? I'm asking because the NodeJS server is created right in the constructor and therefore any call to setStrictSSL won't have any effect.

As discussed in #145 (comment) it would be better to have support for all options at once, rather than 1 of 8.

@robballou
Copy link
Author

That's a good point. I went about adding this backwards: added the browser.strictSSL line and then backtracked so ... probably not :) Sorry I didn't see the other ticket.

I'm not sure the best way to have the driver get this without accepting an options array or the like. I have done things where a constructor uses func_get_args() to figure out if it's getting an array or a number of parameters. If there's a good way to help, let me know. The SSL option scratches my back in a current problem, but it would be best to support it all.

@aik099
Copy link
Member

aik099 commented Jan 27, 2016

I'm not sure the best way to have the driver get this without accepting an options array or the like.

The array is absolutely fine, because this way we can account for Zombie options, that will be added in future. We're just trusting that name of option user specified does match the option on Zombie side.

Maybe instead of modifying this PR you can send another one, because having PR that's title says "adding 1 option" but in the code it's adding all options is a bit confusing.

@aik099
Copy link
Member

aik099 commented Feb 2, 2016

@robballou , PR is coming I suppose?

@robballou
Copy link
Author

Yeah, sorry. I have started a branch here: https://github.com/robballou/MinkZombieDriver/tree/zombie-options. I haven't had time to really check it out though. Do you want a PR for that and we can hash out changes there?

@aik099
Copy link
Member

aik099 commented Feb 2, 2016

Sure, you can send a PR from that.

@stof
Copy link
Member

stof commented Mar 5, 2016

Closing this PR in favor of #154 supporting more options

@stof stof closed this Mar 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants