Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated testcase for Schedule should result in schedule_id of Task to be set to None #4104

Merged
merged 4 commits into from
Feb 20, 2025

Conversation

jpbruinsslot
Copy link
Contributor

@jpbruinsslot jpbruinsslot commented Feb 18, 2025

Changes

The related issue was solved and was a local inconsistency. This PR will only add some more checks in the testcases.

Issue link

Closes #4101

QA notes

See changes, the tests should run correctly.


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@jpbruinsslot jpbruinsslot added the mula Issues related to the scheduler label Feb 18, 2025
@jpbruinsslot jpbruinsslot self-assigned this Feb 18, 2025
@jpbruinsslot jpbruinsslot changed the title Fix Schedule should result in schedule_id of Task to be set to None Updated testcase for Schedule should result in schedule_id of Task to be set to None Feb 20, 2025
@jpbruinsslot jpbruinsslot marked this pull request as ready for review February 20, 2025 12:01
@jpbruinsslot jpbruinsslot requested a review from a team as a code owner February 20, 2025 12:01
Copy link
Contributor

@ammar92 ammar92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, new test look good 👍

@underdarknl underdarknl merged commit 5c69e3a into main Feb 20, 2025
22 checks passed
@underdarknl underdarknl deleted the fix/mula/schedule-ondelete-setnone branch February 20, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mula Issues related to the scheduler
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Removing Schedule should result in schedule_id of Task to be set to None
3 participants