Skip to content

Commit

Permalink
Merge branch 'master' into check-mats
Browse files Browse the repository at this point in the history
  • Loading branch information
jonpvandermause committed Oct 12, 2024
2 parents dd06a71 + 2f1aaa0 commit 359cdf2
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/flare.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ jobs:
- name: Install LAMMPS
run: |
git clone --depth 1 https://github.com/lammps/lammps.git lammps
git clone --depth 1 --branch release https://github.com/lammps/lammps.git lammps
cd lammps/src
cp pair_hybrid.* pair_lj_cut.* ..
Expand Down Expand Up @@ -103,7 +103,7 @@ jobs:
- name: Run LAMMPS tests with Kokkos
run: |
export lmp="$(pwd)/lammps/build/lmp -k on t 4 -sf kk -pk kokkos newton on neigh full"
export lmp="$(pwd)/lammps/build/lmp -k on t 4 -sf kk -pk kokkos newton on neigh half"
cd tests
pytest test_lammps.py
Expand Down
2 changes: 1 addition & 1 deletion lammps_plugins/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ where `Si.txt` should be replaced by the name of your mapped model. Then run `lm
### Running on a GPU with Kokkos
See the [LAMMPS documentation](https://docs.lammps.org/Speed_kokkos.html). In general, run
```
lmp -k on g 1 -sf kk -pk kokkos newton on neigh full -in in.script
lmp -k on g 1 -sf kk -pk kokkos newton on neigh half -in in.script
```
When running with MPI, replace `g 1` with the number of GPUs *per node*.

Expand Down
4 changes: 2 additions & 2 deletions lammps_plugins/kokkos/pair_flare_kokkos.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -737,8 +737,8 @@ void PairFLAREKokkos<DeviceType>::init_style()

// always request a full neighbor list

if (neighflag != FULL) {
error->all(FLERR,"Cannot use chosen neighbor list style with pair flare/kk");
if (neighflag == FULL) {
error->all(FLERR,"pair flare/kk requires 'newton on neigh half'");
}

// get available memory from environment variable,
Expand Down
2 changes: 1 addition & 1 deletion lammps_plugins/pair_flare.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ void PairFLARE::coeff(int narg, char **arg) {
void PairFLARE::init_style() {
// Require newton on.
if (force->newton_pair == 0)
error->all(FLERR, "Pair style requires newton pair on");
error->all(FLERR, "Pair style flare requires newton pair on");

// Request a full neighbor list.
neighbor->add_request(this, NeighConst::REQ_FULL);
Expand Down

0 comments on commit 359cdf2

Please sign in to comment.