Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Type Hint for energy_correction #420

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

ShuaishuaiYuan
Copy link
Contributor

Adapted from the Pymatgen PR template.

Summary

Fix the type hint, it can either be a list of float or a single float. so I change it to a union.

Additional dependencies introduced (if any)

N/A

TODO (if any)

N/A

Checklist

N/A

Fix the type hint, it can either be a list of float or a single float. so I change it to a union.
@anjohan
Copy link
Collaborator

anjohan commented Oct 23, 2024

Thank you for the contribution, and for testing out the LMPOTF functionality!

Note that you're the first (known) external user of LMPOTF, please let us know if there are any issues with the tutorial, installation or running the code.

@ShuaishuaiYuan
Copy link
Contributor Author

I enjoyed learning about this. so far so good. I am able to deploy this and run jobs in our clusters. the tutorials have been very helpful so far. Thank you very much! I am happy to continue point out things that I notice later.

@anjohan anjohan merged commit 9f275ca into mir-group:master Oct 23, 2024
6 of 8 checks passed
@ShuaishuaiYuan ShuaishuaiYuan deleted the patch-1 branch October 25, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants