-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bk descriptors #19
Open
YuuuXie
wants to merge
65
commits into
master
Choose a base branch
from
Bk
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Bk descriptors #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Features - The descriptor interface is generalized to Bk - Add lammps support of Bk with multiple kernels, for both potential and variance - Add more unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request wraps up B1, B2, B3 descriptors into a Bk descriptor module. And should be merged after #12
is equivalent to current setting
The lammps files are changed correspondingly.
atom_indices
tosparse_gp.py/update_db
andsparse_gp.cpp/add_training_structure
to allow adding a subset of force labels, such that the Kuf matrix is smaller in the "f" dimensionNotes:
To add descriptors with higher body order, just need to add coefficients (l1, l2, l3 ...; m1, m2, m3, ...) to
coeffs.cpp
and add indices (n1 l1 m1, n2 l2 m2, ... nk lk mk) inindices.cpp
.The original
b1/2/3.cpp
are kept for unit test, but we could delete them and might find better way of doing this.compute
command for variance to Bk descriptorsTodo
The lammps code can be further optimized: