Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Highlight.js 11 #147

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Upgrade to Highlight.js 11 #147

wants to merge 2 commits into from

Conversation

waarissyb
Copy link
Member

@waarissyb waarissyb mentioned this pull request Aug 5, 2021
Closed
@waarissyb
refactor(codeSample): upgrade to Highlight.js 11
334e483 
- Upgrade to Highlight.js and change code accordingly
- Update to latest version of the Github styling for code highlighting
- Fix a regression from PR mirabeau-nl#116; a scroll bar should appear for long code
@waarissyb waarissyb force-pushed the feature/upgrade-highlight.js branch from 17b2f62 to 334e483 Compare August 5, 2021 14:39
Timvdv
Timvdv approved these changes Sep 24, 2021
View reviewed changes
Copy link
Member

@Timvdv Timvdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked it out locally and the highlighting looks good! :)

@waarissyb waarissyb force-pushed the feature/upgrade-highlight.js branch from 56a6247 to ca9e97f Compare November 4, 2021 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Timvdv Timvdv Timvdv approved these changes

@Thomas-Machielsen Thomas-Machielsen Awaiting requested review from Thomas-Machielsen

@scalka scalka Awaiting requested review from scalka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waarissyb @Timvdv