Support ipv6 hosts #279
Open
Support ipv6 hosts #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talex5
reviewed
Sep 30, 2024
unix/capnp_rpc_unix.ml
Outdated
| match Unix.getaddrinfo host "" [Unix.AI_SOCKTYPE Unix.SOCK_STREAM] with | ||
| | {ai_addr = ADDR_INET(addr, _) ; _} :: _ -> addr | ||
| | [] -> Capnp_rpc.Debug.failf "No addresses found for host name %S" host | ||
| | _ -> Capnp_rpc.Debug.failf "Unknown host %S" host |
There was a problem hiding this comment.
It's a bit odd to say "unknown host" where there are multiple matches.
There was a problem hiding this comment.
Indeed this branch was only taken for Unix sockets.
I updated the match to make it explicit.
However, the message is maybe not so relevant anymore. I kept it as it was before, but maybe it deserves to be reworded a bit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR following #278
This is adding support for ipv6 in capnp-rpc-unix.
This has been tested with ocurrent rpc on the server and the client.
For 3. I don’t think this is the best way to do : the format of ip6 host would be
tcp:::1:7000which is not so readable.It is probably better to do
tcp:[::1]:7000but this require more change than simply adding~rev:true.Tell me what do you think of it