Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Systray notification, start minimized #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

john-peterson
Copy link
Member

Adding a a systray notification when you are mentioned in a channel or receive a private message

Adding option to always show the tray icon (to allow systray notifications when not minimized to the systray, for example when pinned to the taskbar in Windows 6.1+).

Adding option to start minimized (convenient when program is autorun or often run minimized).

john-peterson and others added 3 commits January 31, 2013 01:49
… Privmsg)

Adding option to start minimized (convenient when program is autorun or often run minimized)
Disabling URLGrabber because of an unresolved exception
@john-peterson
Copy link
Member Author

Increasing the max command profile length

Problem

Selecting "Option → Preferences → OK" can return

---------------------------
Microsoft Visual C++ Debug Library
---------------------------
Debug Error!

Program: C:\Documents\Programs\HydraIRC\HydraIRC.exe
Module: C:\Documents\Programs\HydraIRC\HydraIRC.exe
File: d:\files\source\programs\hydrairc\repo\hydrairc\prefs.cpp
Line: 3384

Run-Time Check Failure #2 - Stack around the variable 'EscapedString' was corrupted.

(Press Retry to debug the application)
---------------------------
Abort   Retry   Ignore   
---------------------------


>   HydraIRC.exe!Prefs::XML_SaveCommandProfiles(_xmlNode * pParentNode) Line 3384   C++
    HydraIRC.exe!Prefs::SaveProfile(char * ProfileName, char * FileName) Line 3813  C++
    HydraIRC.exe!Prefs::SavePrefs() Line 3840   C++
    HydraIRC.exe!CMainFrame::DoPrefs(int PageNum) Line 1249 C++
    HydraIRC.exe!CMainFrame::OnOptionsPrefs(unsigned short __formal, unsigned short __formal, HWND__ * __formal, int & __formal) Line 1668  C++
    HydraIRC.exe!CMainFrame::ProcessWindowMessage(HWND__ * hWnd, unsigned int uMsg, unsigned int wParam, long lParam, long & lResult, unsigned long dwMsgMapID) Line 255    C++
    HydraIRC.exe!WTL::CMDIFrameWindowImpl<CMainFrame,CHidingMDIWindow,dockwins::CDockingFrameTraitsT<dockwins::CDockingWindowTraits<dockwins::CVC7LikeCaption,1186988032,128>,dockwins::CSimpleSplitterBar<3>,114229248,262400> >::MDIFrameWindowProc(HWND__ * hWnd, unsigned int uMsg, unsigned int wParam, long lParam) Line 1490 C++
    user32.dll!76b362fa()   Unknown
    user32.dll!76b36d3a()   Unknown
    user32.dll!76b36ce9()   Unknown
    user32.dll!76b40d27()   Unknown
    user32.dll!76b4794a()   Unknown
    HydraIRC.exe!ATL::CContainedWindowT<ATL::CWindow,ATL::CWinTraits<1442840576,0> >::DefWindowProcA(unsigned int uMsg, unsigned int wParam, long lParam) Line 4480 C++
    HydraIRC.exe!ATL::CContainedWindowT<ATL::CWindow,ATL::CWinTraits<1442840576,0> >::WindowProc(HWND__ * hWnd, unsigned int uMsg, unsigned int wParam, long lParam) Line 4547  C++
    user32.dll!76b362fa()   Unknown
    user32.dll!76b36d3a()   Unknown
    user32.dll!76b36ce9()   Unknown
    user32.dll!76b3965e()   Unknown
    user32.dll!76b396c5()   Unknown
    comctl32.dll!6782aba1() Unknown
    user32.dll!76b36d91()   Unknown
    user32.dll!76b362fa()   Unknown
    user32.dll!76b36d3a()   Unknown
    user32.dll!76b36ce9()   Unknown
    user32.dll!76b40d27()   Unknown
    user32.dll!76b4794a()   Unknown
    HydraIRC.exe!ATL::CWindowImplBaseT<WTL::CCommandBarCtrlBase,ATL::CWinTraits<1442840576,0> >::DefWindowProcA(unsigned int uMsg, unsigned int wParam, long lParam) Line 3444  C++
    HydraIRC.exe!ATL::CWindowImplBaseT<WTL::CCommandBarCtrlBase,ATL::CWinTraits<1442840576,0> >::WindowProc(HWND__ * hWnd, unsigned int uMsg, unsigned int wParam, long lParam) Line 3511   C++
    user32.dll!76b362fa()   Unknown
    user32.dll!76b36d3a()   Unknown
    user32.dll!76b36ce9()   Unknown
    user32.dll!76b377c4()   Unknown
    user32.dll!76b37bca()   Unknown
    HydraIRC.exe!WTL::CMessageLoop::Run() Line 1169 C++
    HydraIRC.exe!Run(char * __formal, int nCmdShow) Line 1936   C++
    HydraIRC.exe!WinMain(HINSTANCE__ * hInstance, HINSTANCE__ * __formal, char * lpstrCmdLine, int nCmdShow) Line 2212  C++
    HydraIRC.exe!__tmainCRTStartup() Line 547   C
    HydraIRC.exe!WinMainCRTStartup() Line 371   C
    kernel32.dll!75f833aa() Unknown
    ntdll.dll!774b9ef2()    Unknown
    ntdll.dll!774b9ec5()    Unknown

Solution

Change EscapedString so that it doesn't attempt to write outside dest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant