Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(backend): SystemWebhookで送信されるペイロードの型を追加 #14980

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

samunohito
Copy link
Member

What

タイトルの通りです。

Why

fix #14979

Additional info (optional)

  • ローカルでunittestとe2eをそれぞれ実行してエラーが無い事を確認
  • ローカルで実際にwebhookを送信してエラーにならないことを確認

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md ※動作に影響ないので
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Nov 17, 2024
@samunohito samunohito marked this pull request as ready for review November 17, 2024 07:12
Copy link
Contributor

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 79.36508% with 13 lines in your changes missing coverage. Please review.

Project coverage is 39.98%. Comparing base (eef0c89) to head (f10a781).
Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
packages/backend/src/core/WebhookTestService.ts 61.11% 7 Missing ⚠️
...backend/src/core/AbuseReportNotificationService.ts 0.00% 3 Missing ⚠️
packages/backend/src/core/QueueService.ts 57.14% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14980      +/-   ##
===========================================
- Coverage    41.67%   39.98%   -1.70%     
===========================================
  Files         1565     1561       -4     
  Lines       203008   197290    -5718     
  Branches      3678     3608      -70     
===========================================
- Hits         84596    78878    -5718     
  Misses      117840   117840              
  Partials       572      572              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih
Copy link
Contributor

(Off-topic) misskey-jsにWebhookの型を露出させるようにしたらJavaScript/TypeScriptで連携アプリをつくる人に恩恵がありそう

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[refactor] SystemWebhookに設定されるペイロードの型を用意する
2 participants