Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(frontend): デッキ表示時にサイドバーを展開・折りたたみできるように #14983

Merged

Conversation

samunohito
Copy link
Member

What

デッキ表示時のサイドバーに小さな矢印ボタンを追加し、サイドバーを展開・折りたたみ出来るようにしました。この機能は常に広げておきたい人、常に折りたたんでおきたい人向けというよりも、状況に応じて頻繁に切り替えたい人向けの機能です。
image

Why

fix #14981

Additional info (optional)

実際にローカルで動作確認

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Nov 17, 2024
@samunohito
Copy link
Member Author

issueたてて即prしてるゆえに要否判断も何もない状態ですが、不要であれば遠慮なくcloseください。

@samunohito samunohito marked this pull request as ready for review November 17, 2024 09:02
Copy link

codecov bot commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 64 lines in your changes missing coverage. Please review.

Project coverage is 19.13%. Comparing base (eef0c89) to head (5e59f51).
Report is 12 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/ui/_common_/navbar.vue 0.00% 64 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14983       +/-   ##
============================================
- Coverage    41.67%   19.13%   -22.54%     
============================================
  Files         1565      727      -838     
  Lines       203008   103687    -99321     
  Branches      3678      992     -2686     
============================================
- Hits         84596    19843    -64753     
+ Misses      117840    83289    -34551     
+ Partials       572      555       -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samunohito samunohito marked this pull request as draft November 17, 2024 09:04
@samunohito samunohito marked this pull request as ready for review November 17, 2024 09:05
@samunohito samunohito marked this pull request as draft November 17, 2024 09:25
@samunohito
Copy link
Member Author

firefoxだとスクロールバーと干渉することが分かったので少し修正します

@syuilo
Copy link
Member

syuilo commented Nov 17, 2024

デザインは自分がいい感じ™︎にしときます

@samunohito
Copy link
Member Author

オッ

よろしくお願いします!

@samunohito samunohito marked this pull request as ready for review November 17, 2024 09:33
@syuilo
Copy link
Member

syuilo commented Nov 17, 2024

Animation3

@samunohito
Copy link
Member Author

sugoi

@syuilo
Copy link
Member

syuilo commented Nov 17, 2024

(スクロールバーは左に表示するようにした)

@syuilo syuilo merged commit 0df6c79 into misskey-dev:develop Nov 18, 2024
9 checks passed
@syuilo
Copy link
Member

syuilo commented Nov 18, 2024

👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

デッキ表示時に左サイドバーを手軽に縮めたり広げたりする機能
2 participants