Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): お知らせ作成時に画像URL入力欄を空欄に変更できないのを修正 #14990

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

eternal-flame-AD
Copy link
Contributor

What

Fixes #14976

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Nov 18, 2024
Copy link
Contributor

github-actions bot commented Nov 18, 2024

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -3219,7 +3219,7 @@
                       "string",
                       "null"
                     ],
-                    "minLength": 1
+                    "minLength": 0
                   },
                   "icon": {
                     "type": "string",

Get diff files from Workflow Page

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 39.97%. Comparing base (eed45c7) to head (fdd43e6).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...server/api/endpoints/admin/announcements/create.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14990      +/-   ##
===========================================
- Coverage    39.97%   39.97%   -0.01%     
===========================================
  Files         1561     1561              
  Lines       197256   197257       +1     
  Branches      3607     3606       -1     
===========================================
- Hits         78849    78847       -2     
+ Misses      117835   117804      -31     
- Partials       572      606      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: おさむのひと <[email protected]>
@eternal-flame-AD eternal-flame-AD changed the title fix(backend): アナウンスメントを作成ときに画像URLを後悔できないのを修正 fix(backend): お知らせ作成時に画像URL入力欄を空欄に変更できないのを修正 Nov 18, 2024
@eternal-flame-AD
Copy link
Contributor Author

https://github.com/misskey-dev/misskey/actions/runs/11884135456/job/33111877091?pr=14990#step:11:945

I have this problem on my Forgejo CI too (happened before this commit so not related).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
2 participants