-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge others work #36
base: master
Are you sure you want to change the base?
Conversation
Hmm @edillmann I'll go ahead and merge @apatil's PR directly while taking care of the comments @trisk and I had. Also, unless he doesn't particularly want to and you need the functionality I'd rather @calmh submit the commits himself. |
quick update: just ran into a failing test for |
(The zfs package is something I used for one thing but currently don't, so I don't have the drive to integrate my changes, whatever they were, at the moment. :) |
@calmh thats fair. @edillmann can you rebase on top of master, I've merged w/ tweaks @apatil's PR. |
I repushed this PR, tests are OK |
@edillmann breaking the API is a no-go. You're going to have to define other functions. I'd suggest something mimicking https://godoc.org/github.com/mistifyio/gozfs#Datasets, but unfortunately a different name :( Review status: 0 of 4 files reviewed at latest revision, all discussions resolved. Comments from the review on Reviewable.io |
I create this pull request to merge work done by apatil and calmh