-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
this commit contains minimal changes for the Need Help/Troubleshoot #… #3377
Open
cindyloo
wants to merge
18
commits into
mit-cml:master
Choose a base branch
from
cindyloo:ios-companion-app-troubleshooting-3374
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
this commit contains minimal changes for the Need Help/Troubleshoot #… #3377
cindyloo
wants to merge
18
commits into
mit-cml:master
from
cindyloo:ios-companion-app-troubleshooting-3374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it-cml#3374 # Conflicts: # appinventor/aicompanionapp/src/Base.lproj/Main.storyboard
…it-cml#3374 # Conflicts: # appinventor/aicompanionapp/src/Base.lproj/Main.storyboard
…it-cml#3374 # Conflicts: # appinventor/aicompanionapp/src/Base.lproj/Main.storyboard
…it-cml#3374 # Conflicts: # appinventor/aicompanionapp/src/Base.lproj/Main.storyboard # Conflicts: # appinventor/aicompanionapp/src/Base.lproj/Main.storyboard
…it-cml#3374 # Conflicts: # appinventor/aicompanionapp/src/Base.lproj/Main.storyboard
…it-cml#3374 # Conflicts: # appinventor/aicompanionapp/src/Base.lproj/Main.storyboard
…mit-cml#3356) * remove unnecessary changes * Fix inconsistent css class name --------- Co-authored-by: SusanRatiLane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ x] I branched from master
My pull request has master as the base
What does this PR accomplish?
please review #3374 here, but basically
on iOS, there are 3 screens before the final "scan/code" screen that are to inform the user of what s/he should do. However, many don't read and just click through to the scan/code screen and then don't know what to do. Also, if they Deny access to the camera or to the wifi, they will not be able to connect at all. We can help them by giving them a Need Help button and informing them what to do to remedy their situation. (rather than deleting the app and starting over)
basic modifications:
swap blue for green scan button, add graphic, move and resize current buttons. Remove large dark grey instruction graphic. add Need Help? button that shows ip/version info and help in popup