fix to work on default postgres db #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcdickinson
reviewed
Jul 21, 2023
| # database because none of our operations need to query the target | ||
| # database. | ||
| pg_client = PGClient( | ||
| host=settings.db.host, | ||
| port=settings.db.port, | ||
| user=settings.db.username, | ||
| password=settings.db.password, | ||
| dbname="postgres", | ||
| dbname="template1", |
There was a problem hiding this comment.
Would it make more sense to use template0 here? That database should never be modified by users, but template1 is intended to be modified by users to provide per-cluster defaults for new databases. It seems like it might be a valid use case to use dslr to snapshot your template1 DB while experimenting with changes to it locally, whereas that should never be the case for template0.
Relevant docs: https://www.postgresql.org/docs/current/manage-ag-templatedbs.html
There was a problem hiding this comment.
Thanks for the review @bcdickinson . I agree. I can accept this PR if we can change it to use template0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #15