Modified transaction regex to allow amount without decimal places. #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given statement with the following line
:61:2012031203CR20NMSCVS0015060871
the parser throws
System.Data.InvalidExpressionException: '2012031203CR20NMSCVS0015060871'
I narrowed it down to the fact that the amount in this case does not contain the decimal separator.
As seen in the regex, the decimal separator is expected.
(?<ammount>\d*[,.]\d{0,2})
SharpMt940Lib.Core/Raptorious.SharpMt940Lib/Transaction.cs
Line 130 in 937177b
In the PR, you can see two changes to the regex:
Simply adding {0,1} to the 'ammount' group did not help, I also had to remove the '?' from the 'fundscode' group.