Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readability in RequiredOverridesCheck #32

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Improve readability in RequiredOverridesCheck #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/main/java/domain/RequiredOverridesCheck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,9 @@ public Set<Message> run(Map<String, ClassData> classes, Configuration config) {
private void validateCompareToImpliesEquals(ClassData classData, Set<Message> messages) {
if (classData.getInterfaceFullNames().contains("java.lang.Comparable")) {
String[] compareToParamTypes = new String[] {classData.getFullName()};
if (classHasMethod(classData, "compareTo", compareToParamTypes) && !classHasMethod(classData, "equals", TYPES_1_OBJECT)) {
boolean hasCompareTo = classHasMethod(classData, "compareTo", compareToParamTypes);
boolean hasEquals = classHasMethod(classData, "equals", TYPES_1_OBJECT);
if (hasCompareTo && !hasEquals) {
messages.add(new Message(
MessageLevel.WARNING,
"Class implementing Comparable overrides compareTo but not equals",
Expand All @@ -44,7 +46,9 @@ private void validateCompareToImpliesEquals(ClassData classData, Set<Message> me
}

private void validateEqualsImpliesHashCode(ClassData classData, Set<Message> messages) {
if (classHasMethod(classData, "equals", TYPES_1_OBJECT) && !classHasMethod(classData, "hashCode", TYPES_EMPTY)) {
boolean hasEquals = classHasMethod(classData, "equals", TYPES_1_OBJECT);
boolean hasHashCode = classHasMethod(classData, "hashCode", TYPES_EMPTY);
if (hasEquals && !hasHashCode) {
messages.add(new Message(
MessageLevel.ERROR,
"Class overrides equals but not hashCode",
Expand Down
Loading