Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Check in accordance with #2 #6

Merged
merged 5 commits into from
Mar 11, 2024
Merged

Improve Check in accordance with #2 #6

merged 5 commits into from
Mar 11, 2024

Conversation

mkacct
Copy link
Owner

@mkacct mkacct commented Mar 11, 2024

Changes:

  • Check is now an abstract class instead of an interface
  • Checks can now be enabled or disabled by default
  • Deleted a bunch of no longer needed files (and ignored test-generated files)

Resolves #2.

@mkacct mkacct requested a review from rhit-shirakrk March 11, 2024 00:04
@mkacct mkacct merged commit 034276d into main Mar 11, 2024
1 check passed
@mkacct mkacct deleted the fixes branch March 11, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhit-shirakrk rhit-shirakrk rhit-shirakrk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce notion of "default disabled" check
2 participants
@mkacct @rhit-shirakrk