Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BlockingReferences test (failing for now) that reveals #379 #398

Merged
merged 1 commit into from
Dec 18, 2021

Conversation

KvanTTT
Copy link

@KvanTTT KvanTTT commented Aug 15, 2021

Potentially fixed by #385

@AppVeyorBot
Copy link

Build ConfuserEx 851 failed (commit c04ea1dd28 by @KvanTTT)

@KvanTTT KvanTTT force-pushed the BlockingReferences branch from 5f276f4 to e81454d Compare August 15, 2021 14:46
@AppVeyorBot
Copy link

Build ConfuserEx 853 failed (commit 85b170a39b by @KvanTTT)

@KvanTTT
Copy link
Author

KvanTTT commented Sep 2, 2021

@mkaring do have any idea how to fix it?

@mkaring
Copy link
Owner

mkaring commented Oct 16, 2021

Okay, so I found the reason why this is breaking. The issue is the way the renamer processes different assemblies. It does that currently in sequence and there is nothing I can do about that for now. What it needs to do is process all assemblies at once so it can rename the members in proper sequence.

This can't be done without some major reworking. So I "fixed" this, by having ConfuserEx detect this issue and blocking the renaming for all members affected by it. This fix is now in #425
That is the best I can come up with right now.

A better solution would be to delay the renaming for parts of an assembly until after another assembly has been processed.

@mkaring mkaring added the bug Something isn't working label Oct 16, 2021
@mkaring mkaring added this to the 1.6 milestone Oct 16, 2021
@mkaring mkaring merged commit e81454d into mkaring:master Dec 18, 2021
@KvanTTT KvanTTT deleted the BlockingReferences branch December 18, 2021 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants