Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Improper Method Call (Replace mktemp with mkstemp) #557

Closed

Conversation

fazledyn-or
Copy link

@fazledyn-or fazledyn-or commented Oct 23, 2023

Details

While triaging your project, our bug fixing tool generated the following message(s)-

In file: pabotprofiler.py, there is a method that creates a temporary file using an unsafe API mktemp. The use of this method is discouraged in the Python documentation. iCR suggested that a temporary file should be created using mkstemp which is a safe API. iCR replaced the usage of mktemp with mkstemp.

Changes

  • Replaced mktemp with mkstemp method
  • Safely closed the file descriptor to prevent a file descriptor leak

Previously Found & Fixed

CLA Requirements

This section is only relevant if your project requires contributors to sign a Contributor License Agreement (CLA) for external contributions.

All contributed commits are already automatically signed off.

The meaning of a signoff depends on the project, but it typically certifies that committer has the rights to submit this work under the same license and agrees to a Developer Certificate of Origin (see https://developercertificate.org/ for more information).
- Git Commit SignOff documentation

Sponsorship and Support

This work is done by the security researchers from OpenRefactory and is supported by the Open Source Security Foundation (OpenSSF): Project Alpha-Omega. Alpha-Omega is a project partnering with open source software project maintainers to systematically find new, as-yet-undiscovered vulnerabilities in open source code - and get them fixed – to improve global software supply chain security.

The bug is found by running the Intelligent Code Repair (iCR) tool by OpenRefactory and then manually triaging the results.

@fazledyn-or fazledyn-or changed the title Replaced 'mktemp with mkstemp` Replaced mktemp with mkstemp Oct 23, 2023
@fazledyn-or fazledyn-or changed the title Replaced mktemp with mkstemp Fix: Improper Method Call (Replace mktemp with mkstemp) Oct 23, 2023
@fazledyn-or fazledyn-or force-pushed the Fix_Improper_Method_Call branch from ac70538 to 9a040ef Compare October 23, 2023 09:09
@mkorpela
Copy link
Owner

The profiler is a separate debug tool that is not a "real" part of the project.
Although I appreciate contributions I think I would be just promoting your automation when accepting this and not really bringing any value for the community of the users. Thus closing this.

@mkorpela mkorpela closed this Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants