-
Notifications
You must be signed in to change notification settings - Fork 448
Makes Examples Mobile-friendly #217
base: release
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @joeyklee π€ Let me know if I need to make any changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @justsml - I made a note about where the sketch.js
file should live below. Would it be possible to undo that revision?
<title>BodyPix with Webcam</title> | ||
<script src="https://unpkg.com/[email protected]/dist/ml5.min.js" type="text/javascript"></script> | ||
|
||
<style></style> | ||
<script src="sketch.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct me if I'm mistaken, but we should always try to leave the sketch.js
at the end of the body tag to make sure that the DOM elements are loaded before calling the script.
This example will work fine this way, but for consistency, we should just always call script.js
at the end of the index.html.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the reply!
That sounds about right, I'll have time to hack on it later today π€
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a bunch! Let me know whenever you're ready and I can review. If you're able to resolve any of the merge conflicts that would be great, otherwise I can also take care :)
Many thanks!
Hey @justsml! We're archiving this repository and moving its contents into the core ml5-library repository (more context on issue #809 and pull request #831). We appreciate your contributions and would love it if you'd consider reopening this pull request on the ml5-library repo! Thanks! |
Dear ml5 community, π
I'm making a Pull Request(PR). Please see the details below.
β Step 1: Which branch are you submitting to? π²
β Step 2: Describe your Pull Request π