Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore trailing whitespace lines in spl.txt files #1584

Merged
merged 6 commits into from
Jan 30, 2024
Merged

Ignore trailing whitespace lines in spl.txt files #1584

merged 6 commits into from
Jan 30, 2024

Conversation

psyhtest
Copy link
Contributor

Fixes #1581.

@psyhtest psyhtest requested a review from a team as a code owner January 26, 2024 00:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 26, 2024 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@psyhtest psyhtest mentioned this pull request Jan 26, 2024
Closed
arjunsuresh
arjunsuresh approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@arjunsuresh arjunsuresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Anton. It'll save time for power submitters.

@arjunsuresh
Copy link
Contributor

@pgmpablo157321 can you please merge this? It'll save time for power submitters.

@psyhtest psyhtest mentioned this pull request Jan 26, 2024
Merged
@psyhtest psyhtest mentioned this pull request Jan 26, 2024
Open
@psyhtest
Copy link
Contributor Author

Unfortunately, Submission UI still rejects our test submission because of this issue.

@arjunsuresh
Copy link
Contributor

Same for us.

@pgmpablo157321 pgmpablo157321 merged commit a04b1f5 into mlcommons:master Jan 30, 2024
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
@psyhtest psyhtest deleted the fix-power-whitespace branch January 30, 2024 18:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pgmpablo157321 pgmpablo157321 pgmpablo157321 approved these changes

@arjunsuresh arjunsuresh arjunsuresh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[URGENT] Power issues
3 participants
@psyhtest @arjunsuresh @pgmpablo157321