Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report improvement - support output of IDs in a json file #2053

Closed
wants to merge 159 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
159 commits
Select commit Hold shift + click to select a range
d8f0d7e
Update generate_final_report.py
arjunsuresh Oct 31, 2024
390a8cb
Merge branch 'master' into dev
arjunsuresh Nov 7, 2024
6b1a0f8
Fix sdxl (#1911)
arjunsuresh Nov 7, 2024
a4ba51f
Fixes for filtering invalid results
arjunsuresh Nov 7, 2024
7097ef5
Merge branch 'master' into dev
arjunsuresh Nov 7, 2024
190ee41
Merge 7097ef540bfa0286c65c81fbfdcb300e6d54f770 into d3c01ed3de6618a8d…
arjunsuresh Nov 7, 2024
451b310
[Automated Commit] Format Codebase
arjunsuresh Nov 7, 2024
4c109ea
Update preprocess_submission.py
arjunsuresh Nov 7, 2024
40c1fe0
Added an option to pass in sample_ids.txt for SDXL accuracy check
arjunsuresh Nov 7, 2024
2a61df9
Merge 40c1fe0c28364b243b5944b3569000611ddf2b7d into d3c01ed3de6618a8d…
arjunsuresh Nov 7, 2024
89a2ffe
[Automated Commit] Format Codebase
arjunsuresh Nov 7, 2024
69ffdc0
Update accuracy_coco.py
arjunsuresh Nov 7, 2024
76b703b
Merge 69ffdc0aa783f9127af612a7de57c6329703c1dc into d3c01ed3de6618a8d…
arjunsuresh Nov 7, 2024
d1d642e
[Automated Commit] Format Codebase
arjunsuresh Nov 7, 2024
8d3b8ab
Fix typo
arjunsuresh Nov 7, 2024
b09b1ef
Not use default for sample_ids.txt
arjunsuresh Nov 8, 2024
857494f
Merge branch 'master' into dev
arjunsuresh Nov 12, 2024
df5049d
Update requirements.txt (#1907)
arjunsuresh Nov 14, 2024
a7e8c8a
Fix preprocess_sudbmission for a bug
arjunsuresh Nov 15, 2024
213c239
Fix conflict
arjunsuresh Nov 15, 2024
8915a90
Update submission_checker.py | Removed TEST05
arjunsuresh Nov 16, 2024
36d5b74
Merge branch 'master' into dev
arjunsuresh Nov 16, 2024
da9e6bb
Fix to SDXL accuracy output
arjunsuresh Nov 21, 2024
db7fb38
Merge branch 'master' into dev
arjunsuresh Nov 21, 2024
13cd2e0
Added exists checks for rmtree in preprocess_submission script
arjunsuresh Nov 21, 2024
0abd369
Merge 13cd2e0abc98a36601e125f60dc96bc13738dc62 into 35c7e1f0dbbd1a63b…
arjunsuresh Nov 21, 2024
db5e737
[Automated Commit] Format Codebase
arjunsuresh Nov 21, 2024
dbecd2b
Delete .github/workflows/format.yml
arjunsuresh Nov 21, 2024
011a0d1
Delete .github/scripts directory
arjunsuresh Nov 21, 2024
d04ae63
Update build_wheels.yml | Added src distribution
arjunsuresh Nov 22, 2024
1923b01
Update VERSION.txt
arjunsuresh Nov 22, 2024
dc1acd3
Update build_wheels.yml
arjunsuresh Nov 22, 2024
dac78f5
Update VERSION.txt
arjunsuresh Nov 22, 2024
5443e07
Update pyproject.toml
arjunsuresh Nov 22, 2024
cae5eb2
Increment version to 4.1.26
arjunsuresh Nov 22, 2024
3b1031f
Update MANIFEST.in
arjunsuresh Nov 22, 2024
15581e2
Increment version to 4.1.27
arjunsuresh Nov 22, 2024
0511f95
Update pyproject.toml
arjunsuresh Nov 22, 2024
03911ac
Increment version to 4.1.28
arjunsuresh Nov 22, 2024
2418e81
Update build_wheels.yml
arjunsuresh Nov 22, 2024
6e1bcfd
Update VERSION.txt
arjunsuresh Nov 22, 2024
62949d0
Update accuracy_coco.py
arjunsuresh Nov 24, 2024
5314c5c
Making sdxl run thread safe
arjunsuresh Nov 30, 2024
130413b
Merge branch 'master' into dev
arjunsuresh Dec 3, 2024
3b90f6f
Merge branch 'master' into dev
arjunsuresh Dec 3, 2024
509f555
Create format.yml | Run format on push instead of PR
arjunsuresh Dec 4, 2024
6137dbf
Merge master
arjunsuresh Dec 8, 2024
17dc9aa
Update backend_pytorch.py | Fix lock usage
arjunsuresh Dec 8, 2024
dc7be47
Upgrade loadgen version to 5.0 (#1962)
nvzhihanj Dec 9, 2024
d64509d
Fix loadgen build for version numbers having "0" (#1967)
arjunsuresh Dec 9, 2024
b149bec
Increment version to 5.0.1
pgmpablo157321 Dec 9, 2024
0a9b2e4
Fix Dockerfile for 405B (#1960)
nvzhihanj Dec 10, 2024
47422d1
Add llama3 metrics + remove llama3-99.9 (#1973)
pgmpablo157321 Dec 11, 2024
070ef4d
Fix submission checker for v5.0 rgat (#1974)
arjunsuresh Dec 12, 2024
2da8aee
Fix test05 seeds missing error for v5.0 submission checker (#1976)
arjunsuresh Dec 12, 2024
b4d72fb
Fix llama3-405B docker workflow and performance sample count (#1978)
nvzhihanj Dec 13, 2024
a2c8a36
Increment version to 5.0.2
mrmhodak Dec 13, 2024
a988a32
Fix submission generation for v5.0 (#1981)
arjunsuresh Dec 13, 2024
e24ba21
More minor fixes for llama3.1-405b (#1983)
nvzhihanj Dec 17, 2024
659e563
Remove unused rgat files (#1961)
pgmpablo157321 Dec 18, 2024
f4c1f9a
Update docker GPU, avoid long build time (#1966)
pgmpablo157321 Dec 18, 2024
ea5153f
Require equal issue mode for R-GAT (#1968)
pgmpablo157321 Dec 18, 2024
281189a
Increment version to 5.0.3
mrmhodak Dec 18, 2024
ab05233
Docs update for r-gat (#1969)
arjunsuresh Dec 18, 2024
a65114b
[Automated Commit] Format Codebase
mlcommons-bot Dec 18, 2024
99a2015
Update automated run command section - R-GAT (#1970)
anandhu-eng Dec 18, 2024
aeb415e
Unify llama3 names to llama3.1-405b (#1982)
pgmpablo157321 Dec 19, 2024
8a319f0
Increment version to 5.0.4
mrmhodak Dec 19, 2024
2d4360f
Create test-rgat.yml (#1984)
arjunsuresh Dec 19, 2024
1a51a95
Update compliance test table (#1987)
pgmpablo157321 Dec 19, 2024
9309ef7
Create benchmark-checklist.md for r-gat (#1985)
arjunsuresh Dec 19, 2024
d9f1b6f
Increment version to 5.0.5
arjunsuresh Dec 20, 2024
3b5497c
Don't do a loadgen release from dev branch
arjunsuresh Dec 20, 2024
81983e5
Added python3.12, 3.13 to loadgen test
arjunsuresh Dec 20, 2024
ff2e54b
Update format.yml | Don't format power_checker being synced from powe…
arjunsuresh Dec 20, 2024
5f7c4ba
Merge branch 'master' into dev
arjunsuresh Dec 20, 2024
e9354d8
Update index.md | Update accuracy for r-gat
arjunsuresh Dec 20, 2024
76047ff
Update benchmark-checklist.md for r-gat
arjunsuresh Dec 20, 2024
45bb01b
Update CM commands in R-GAT README.md
arjunsuresh Dec 20, 2024
293d4ea
Update README.md
arjunsuresh Dec 20, 2024
c3408dd
Merge branch 'master' into dev
arjunsuresh Dec 21, 2024
1416bbd
Create reset-branch.yml
arjunsuresh Dec 21, 2024
b2ce7c8
Create auto-update-dev.yml
arjunsuresh Dec 22, 2024
1162c25
Tested and fixed SDXL README (#1997)
sahilavaran Dec 23, 2024
b91d6f2
Update preprocess_submission.py
arjunsuresh Dec 23, 2024
d6faf23
Update README.md
sahilavaran Dec 25, 2024
5c44891
Update README.md | added the outdirname in the CM command
sahilavaran Dec 25, 2024
d679f14
Update README.md | added the outdirname in the CM Command
sahilavaran Dec 25, 2024
c6e149d
Merge branch 'mlcommons:dev' into dev
sahilavaran Dec 25, 2024
390d934
include cm commands - accuracy and calibration
anandhu-eng Dec 23, 2024
9340b79
Update README.md
anandhu-eng Dec 23, 2024
5da0abe
Update README.md | added the outdirname in the CM command
sahilavaran Dec 25, 2024
9a32069
Merge branch 'mlcommons:dev' into dev
sahilavaran Dec 26, 2024
ff6d245
Update README.md| added outdirname in the CM command
sahilavaran Dec 30, 2024
69ff400
Support audit.conf with static mlperf.conf
arjunsuresh Dec 30, 2024
e11f6cd
Support audit.conf with static mlperf.conf
arjunsuresh Dec 30, 2024
cb18921
[Automated Commit] Format Codebase
mlcommons-bot Dec 30, 2024
a5c1552
Update test_settings_internal.cc | Fix conf_type usage
arjunsuresh Dec 30, 2024
d4f3f2d
Update test_settings_internal.cc
arjunsuresh Dec 30, 2024
ea2ba9c
Fixes to submission checker
arjunsuresh Dec 30, 2024
3d5688a
[Automated Commit] Format Codebase
mlcommons-bot Dec 30, 2024
3f28e99
Merge branch 'dev' into fix_compliance_runs
arjunsuresh Dec 30, 2024
16019e6
[Automated Commit] Format Codebase
mlcommons-bot Dec 30, 2024
58b36e5
Merge pull request #2004 from mlcommons/fix_compliance_runs
arjunsuresh Dec 30, 2024
b7b6790
Merge pull request #2001 from sahilavaran/dev
arjunsuresh Dec 31, 2024
308147a
Update submission_checker.py | Fix rgat performance_sample_count
arjunsuresh Dec 31, 2024
5d5da3c
Update evaluate-accuracy.py | Fixes #2008
arjunsuresh Jan 1, 2025
1146e20
Merge branch 'master' into dev
arjunsuresh Jan 2, 2025
4ba40e2
Update index.md
arjunsuresh Jan 6, 2025
a893166
Update index.md
arjunsuresh Jan 6, 2025
194aeda
Update index.md
arjunsuresh Jan 6, 2025
bab97ff
Update submission generation steps (WIP)
arjunsuresh Jan 6, 2025
318110c
add submission generation graphs for local sync and through github re…
anandhu-eng Jan 6, 2025
41721df
Update index.md
arjunsuresh Jan 6, 2025
a8cdcaf
Update index.md
arjunsuresh Jan 6, 2025
6eda9f1
Update index.md
arjunsuresh Jan 6, 2025
36db7cc
Update index.md
arjunsuresh Jan 6, 2025
6430b79
Update index.md
arjunsuresh Jan 6, 2025
8425da6
Update index.md
arjunsuresh Jan 6, 2025
6b24ac0
Fixes to submission generation docs
arjunsuresh Jan 6, 2025
1120df8
Fixes to submission generation docs
arjunsuresh Jan 6, 2025
e3ea5ef
Added link to the expected results folder structure
arjunsuresh Jan 7, 2025
2c67b24
add docs for llama3 + inference version upgrade (#2020)
anandhu-eng Jan 7, 2025
c0ed0a8
Update CM run commands for llama3_1-405b (#2019)
anandhu-eng Jan 7, 2025
17960a5
Fixes the submission README
arjunsuresh Jan 7, 2025
51af492
Update README.md
arjunsuresh Jan 7, 2025
cd25f8e
Create test-submission-generation.yml
arjunsuresh Jan 7, 2025
9bcdbee
Update test-submission-generation.yml
arjunsuresh Jan 7, 2025
961efb7
Clean invalid model results in preprocess_submission script
arjunsuresh Jan 7, 2025
ab2fc44
[Automated Commit] Format Codebase
mlcommons-bot Jan 7, 2025
d98eb37
Fixes the submission README
arjunsuresh Jan 7, 2025
37e94c6
Update README.md
arjunsuresh Jan 7, 2025
27827dc
Update README.md
arjunsuresh Jan 7, 2025
a56a251
Update test-submission-generation.yml
arjunsuresh Jan 7, 2025
b8074ef
Auto-merge updates from master branch
invalid-email-address Jan 7, 2025
787282d
Auto-merge updates from master branch
invalid-email-address Jan 7, 2025
0ffb6f3
fix code version (#2025)
anandhu-eng Jan 10, 2025
ceac13d
Auto-merge updates from master branch
invalid-email-address Jan 14, 2025
e836062
[Automated Commit] Format Codebase
mlcommons-bot Jan 14, 2025
bbb7b0b
Auto-merge updates from master branch
invalid-email-address Jan 14, 2025
b42d264
[Automated Commit] Format Codebase
mlcommons-bot Jan 14, 2025
be29f65
Auto-merge updates from master branch
invalid-email-address Jan 14, 2025
7ba430c
Auto-merge updates from master branch
invalid-email-address Jan 14, 2025
8cf95d8
[Automated Commit] Format Codebase
mlcommons-bot Jan 14, 2025
d614d31
Auto-merge updates from master branch
invalid-email-address Jan 14, 2025
e36e6d6
Auto-merge updates from master branch
invalid-email-address Jan 14, 2025
b28042f
Auto-merge updates from master branch
invalid-email-address Jan 14, 2025
73a5852
Auto-merge updates from master branch
invalid-email-address Jan 15, 2025
a24b758
Auto-merge updates from master branch
invalid-email-address Jan 16, 2025
5b1c498
[Automated Commit] Format Codebase
mlcommons-bot Jan 16, 2025
5d25bf5
Auto-merge updates from master branch
invalid-email-address Jan 16, 2025
f924cbe
Auto-merge updates from master branch
invalid-email-address Jan 16, 2025
2f4d5ae
Auto-merge updates from master branch
invalid-email-address Jan 21, 2025
fe517ed
Auto-merge updates from master branch
invalid-email-address Jan 21, 2025
f7fbb20
Auto-merge updates from master branch
invalid-email-address Jan 21, 2025
e502b63
Updated final report generation script to output the list of ids bein…
arjunsuresh Jan 28, 2025
887ba2f
[Automated Commit] Format Codebase
github-actions[bot] Jan 28, 2025
dd7966d
Fix dump_ids in final report generation
arjunsuresh Jan 28, 2025
7a1b820
[Automated Commit] Format Codebase
github-actions[bot] Jan 28, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions main.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,16 @@ def mlperf_inference_implementation_readme(
content = ""

execution_envs = ["Docker", "Native"]
code_version = "r5.0-dev"
code_version = "r4.1-dev"
implementation_run_options = []

if model == "rnnt":
code_version = "r4.0"

if implementation == "reference":
# Tip
if model != "rnnt":
code_version = "r5.0-dev"
if "99.9" not in model and implementation_tips:
content += f"\n{pre_space}!!! tip\n\n"
content += f"{pre_space} - MLCommons reference implementations are only meant to provide a rules compliant reference implementation for the submitters and in most cases are not best performing. If you want to benchmark any system, it is advisable to use the vendor MLPerf implementation for that system like Nvidia, Intel etc.\n\n"
Expand Down Expand Up @@ -502,7 +504,8 @@ def get_common_info(spaces, implementation, model):
info += f"\n{pre_space}!!! tip\n\n"
info += f"{pre_space} - Number of threads could be adjusted using `--threads=#`, where `#` is the desired number of threads. This option works only if the implementation in use supports threading.\n\n"
info += f"{pre_space} - Batch size could be adjusted using `--batch_size=#`, where `#` is the desired batch size. This option works only if the implementation in use is supporting the given batch size.\n\n"
info += f"{pre_space} - `_r4.1-dev` could also be given instead of `_r5.0-dev` if you want to run the benchmark with the MLPerf version being 4.1.\n\n"
if implementation.lower() == "reference":
info += f"{pre_space} - `_r4.1-dev` could also be given instead of `_r5.0-dev` if you want to run the benchmark with the MLPerf version being 4.1.\n\n"
if model == "rgat":
info += f"{pre_space} - Add `--env.CM_DATASET_IGBH_PATH=<Path to IGBH dataset>` if you have already downloaded the dataset. The path will be automatically mounted when using docker run.\n\n"
info += f"{pre_space} - Add `--env.CM_ML_MODEL_RGAT_CHECKPOINT_PATH=<Path to R-GAT model checkpoint>` if you have already downloaded the model. The path will be automatically mounted when using docker run.\n\n"
Expand Down
24 changes: 21 additions & 3 deletions tools/submission/generate_final_report.py
Original file line number Diff line number Diff line change
Expand Up @@ -283,16 +283,34 @@ def MakeUniqueID(x):
"Unique ID (e.g. for Audit)"],
inplace=True,
)
id_dict = {
key: 1 + value
for (value, key) in enumerate(pd.unique(df["Unique ID (e.g. for Audit)"]))
if os.path.exists("ids.json"):
with open("ids.json", "r") as f:
id_dict = json.load(f)
else:
id_dict = {}
cur_keys = id_dict.keys()
cur_ids = id_dict.values()
new_keys = [
a for a in pd.unique(
df["Unique ID (e.g. for Audit)"]) if a not in cur_keys]
if cur_ids:
max_cur_id = max(cur_ids)
else:
max_cur_id = 0
id_dict_new = {
key: 1 + value + max_cur_id
for (value, key) in enumerate(new_keys)
}
id_dict.update(id_dict_new)

df["ID"] = df.apply(
lambda x: "{}-{:04}".format(
args.version, id_dict[x["Unique ID (e.g. for Audit)"]]
),
axis=1,
)
with open("ids.json", "w") as f:
f.write(json.dumps(id_dict, indent=4))

for category in ["closed", "open", "network"]:
for suite in ["datacenter", "edge"]:
Expand Down
Loading