Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update results.cc | Add another significant digit to percentile laten… #2066

Merged
merged 2 commits into from
Feb 1, 2025
Merged

Update results.cc | Add another significant digit to percentile laten… #2066

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1a1db0
Update results.cc | Add another significant digit to percentile laten…
arjunsuresh Jan 31, 2025
23b8096
Merge branch 'master' into arjunsuresh-patch-3
arjunsuresh Feb 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions loadgen/results.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ bool PerformanceSummary::EarlyStopping(
std::to_string(queries_issued) + ").\n" + " * Would discard " +
std::to_string(t - 1) + " highest latency queries.\n" +
" * Early stopping " +
DoubleToString(target_latency_percentile.percentile * 100, 0) +
DoubleToString(target_latency_percentile.percentile * 100, 1) +
"th percentile estimate: " + std::to_string(percentile_estimate);
early_stopping_latency_ss = percentile_estimate;

Expand All @@ -202,7 +202,7 @@ bool PerformanceSummary::EarlyStopping(
if (queries_issued < h_min + 1) {
*recommendation +=
"\n * Not enough queries processed for " +
DoubleToString(multi_stream_percentile * 100, 0) +
DoubleToString(multi_stream_percentile * 100, 1) +
"th percentile\n" +
" early stopping estimate (would need to process at\n least " +
std::to_string(h_min + 1) + " total queries).";
Expand All @@ -218,7 +218,7 @@ bool PerformanceSummary::EarlyStopping(
percentile_estimate = (*sample_latencies)[queries_issued - t];
*recommendation +=
"\n * Early stopping " +
DoubleToString(multi_stream_percentile * 100, 0) +
DoubleToString(multi_stream_percentile * 100, 1) +
"th percentile estimate: " + std::to_string(percentile_estimate);
early_stopping_latency_ms = percentile_estimate;
}
Expand Down Expand Up @@ -273,7 +273,7 @@ bool PerformanceSummary::EarlyStopping(
std::to_string(queries_issued) + ").\n" + " * Would discard " +
std::to_string(t - 1) + " highest latency queries.\n" +
" * Early stopping " +
DoubleToString(target_latency_percentile.percentile * 100, 0) +
DoubleToString(target_latency_percentile.percentile * 100, 1) +
"th percentile estimate: " + std::to_string(percentile_estimate);
early_stopping_latency_ms = percentile_estimate;
break;
Expand Down Expand Up @@ -392,13 +392,13 @@ void PerformanceSummary::LogSummary(AsyncSummary& summary) {

switch (settings.scenario) {
case TestScenario::SingleStream: {
summary(DoubleToString(target_latency_percentile.percentile * 100, 0) +
summary(DoubleToString(target_latency_percentile.percentile * 100, 1) +
"th percentile latency (ns) : ",
target_latency_percentile.sample_latency);
break;
}
case TestScenario::MultiStream: {
summary(DoubleToString(target_latency_percentile.percentile * 100, 0) +
summary(DoubleToString(target_latency_percentile.percentile * 100, 1) +
"th percentile latency (ns) : ",
target_latency_percentile.query_latency);
break;
Expand Down Expand Up @@ -430,14 +430,14 @@ void PerformanceSummary::LogSummary(AsyncSummary& summary) {
switch (settings.scenario) {
case TestScenario::SingleStream: {
summary(DoubleToString(token_target_latency_percentile.percentile * 100,
0) +
1) +
"th first token percentile latency (ns) : ",
token_target_latency_percentile.sample_latency);
break;
}
case TestScenario::MultiStream: {
summary(DoubleToString(token_target_latency_percentile.percentile * 100,
0) +
1) +
"th first token percentile latency (ns) : ",
token_target_latency_percentile.sample_latency);
break;
Expand Down
Loading