Fix SDXL, Retinanet and GPTJ accuracy checker #2094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
arjunsuresh
reviewed
Feb 6, 2025
| @@ -735,19 +735,19 @@ | |||
| ACC_PATTERN = { | |||
| "acc": r"^(?:\{\"accuracy|accuracy)[\": ]*=?\s*([\d\.]+).*", | |||
| "AUC": r"^AUC=([\d\.]+).*", | |||
| "mAP": r".*'(?:mAP|Total)':\s*([\d\.]+)", | |||
| "mAP": r".*(?:mAP|Total)=([\d.]+)%", | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
shall we do "mAP": r".*(?:mAP=|Total:)\s*([\d.]+)" ?
|
I think we need the fix for gptj,retinanet and stable diffusion as the accuracy are failing:
llama2 and mixtral are working fine: |
|
@anandhu-eng we need to fail the tests in MLC when the accuracy value is empty. |
arjunsuresh
reviewed
Feb 6, 2025
| "ROUGE1": r".*'rouge1':\s([\d.]+).*", | ||
| "ROUGE2": r".*'rouge2':\s([\d.]+).*", | ||
| "ROUGEL": r".*'rougeL':\s([\d.]+).*", | ||
| "ROUGE1": r".*'rouge1':\s+'([\d.]+)'.*", |
There was a problem hiding this comment.
shall we do "ROUGE1": r".*'rouge1':\s+'?([\d.]+)'?.*", to make it work for both gptj and other LLMs?
There was a problem hiding this comment.
Thanks for catching, I wasn't testing llama
|
This will catch such failures in future. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@arjunsuresh @pgmpablo157321 to help merge.
The accuracy checker is failing due to wrong regex pattern.