Skip to content

Commit

Permalink
Fix Bug: use unsorted scores to create index
Browse files Browse the repository at this point in the history
  • Loading branch information
pgmpablo157321 committed Oct 10, 2023
1 parent 9b25d4a commit 0704342
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion mlperf_logging/result_summarizer/result_summarizer.py
Original file line number Diff line number Diff line change
Expand Up @@ -360,6 +360,9 @@ def _compute_strong_scaling_scores(desc, system_folder, usage, ruleset):
system,
benchmark,
))

if has_power:
unsorted_scores = scores.copy()

if dropped_scores <= max_dropped_scores:
olympic_avg = _compute_olympic_average(
Expand All @@ -370,7 +373,7 @@ def _compute_strong_scaling_scores(desc, system_folder, usage, ruleset):
benchmark_scores[benchmark] *= scaling_factor

if has_power and dropped_scores <= max_dropped_scores:
index = [i[0] for i in sorted(enumerate(scores), key=lambda x:x[1])]
index = [i[0] for i in sorted(enumerate(unsorted_scores), key=lambda x:x[1])]
olympic_avg = _index_olympic_average(
power_scores, index, dropped_scores, max_dropped_scores)
if olympic_avg is not None:
Expand Down

0 comments on commit 0704342

Please sign in to comment.