Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for logging to file and console #13

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

sujik18
Copy link

@sujik18 sujik18 commented Jan 18, 2025

Fix for issue #12

@sujik18 sujik18 requested a review from a team as a code owner January 18, 2025 07:08
Copy link

MLCommons CLA bot:
Thank you very much for your submission, we really appreciate it. Before we can accept your contribution, we ask that you sign the MLCommons CLA (Apache 2). Please use this [Google form] (https://forms.gle/Ew1KkBVpyeJDuRw67) to initiate authorization. If you are from an MLCommons member organization, we will request that you be added to the CLA. If you are not from a member organization, we will email you a CLA to sign. For any questions, please contact [email protected].
0 out of 1 committers have signed the MLCommons CLA.
@sujik18
You can retrigger this bot by commenting recheck in this Pull Request

@sujik18
Copy link
Author

sujik18 commented Jan 18, 2025

recheck

Copy link
Contributor

@arjunsuresh arjunsuresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @sujik18 Can you please add an option to input the log file path too?

@arjunsuresh arjunsuresh changed the base branch from main to dev January 18, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants