feat: add contract type #245
Open
+400
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I only do tests on the contract type, I will probably add some extra tests directly on the `ContractTestCase'. |
mlebreuil
requested changes
Mar 1, 2025
There was a problem hiding this comment.
@antoinekh, thanks for this valuable addition !
Small comment: many formatting changes are mixed with relevant changes.
Could these be removed ?
I am open to defining additional formatting guidelines. But we should be on the same page to avoid mixing formatting and fonctionnal changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone,
Related to #225.
Add contract type model, the aim is to have a generic model to be able to specify the contract type.
This will help to differentiate contracts.
Some examples idea: support, premium support, hardware, 24/7_support, 4h_support, master_contract...
The contract type will then be visible on the target.
The colour field is visible on every target.
This will help to manage when we have a lot of contracts
Ruff check OK
Tests OK
Let me know what you think
Best regards,
Antoine