Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add StringUtil::toUTF8() #13

Merged
merged 4 commits into from
Feb 27, 2024
Merged

Add StringUtil::toUTF8() #13

merged 4 commits into from
Feb 27, 2024

Conversation

spawnia
Copy link
Member

@spawnia spawnia commented Feb 20, 2024 •
edited
Loading

  • Added automated tests
  • Documented for all relevant versions
  • Updated the changelog

Changes

Add StringUtil::toUTF8().

Breaking changes

None.

@spawnia spawnia requested a review from sp3259 February 20, 2024 11:06
sp3259
sp3259 reviewed Feb 21, 2024
View reviewed changes
Copy link
Member

@sp3259 sp3259 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the pipeline

@spawnia
Copy link
Member Author

spawnia commented Feb 21, 2024

Please check the pipeline

It is failing due to a drop in code coverage. The conditionals for different UTF variants are at fault. I don't think we need to add test cases for all of them and can safely ignore the failing pipeline steps and merge regardless.

@spawnia spawnia added the enhancement New feature or request label Feb 21, 2024
@spawnia spawnia merged commit 139c807 into master Feb 27, 2024
30 of 32 checks passed
@spawnia spawnia deleted the to-utf-8 branch February 27, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sp3259 sp3259 sp3259 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spawnia @sp3259