Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clang format #1635

Merged
merged 5 commits into from
Feb 27, 2025
Merged

Clang format #1635

merged 5 commits into from
Feb 27, 2025

Conversation

bmatherly
Copy link
Member

As discussed on the forum.

This is more change that I expected. But I don't see anything offensive.

@bmatherly bmatherly requested a review from ddennedy February 21, 2025 03:51
Copy link
Member

@ddennedy ddennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to change .github/workflows/check-code-format.yml

@bmatherly
Copy link
Member Author

You also need to change .github/workflows/check-code-format.yml

Good idea. Done. And i tested the workflow with passing and failing formatting (look at the commit history).
This might be a good one to squash due to all the commit noise.

@ddennedy ddennedy merged commit 5437715 into master Feb 27, 2025
1 check passed
@ddennedy ddennedy deleted the clang-format branch February 27, 2025 05:04
@ddennedy ddennedy added this to the v25.03 milestone Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants