Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help available in English #33

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Help available in English #33

merged 1 commit into from
Feb 7, 2025

Conversation

CyrilleB79
Copy link
Collaborator

Issue

In the add-on store, the help for this add-on is not available in English, nor in any other language except zh-CN and uk for which there are translations.

I guess it's due to README file name being uppercase instead of lowercase. On my Windows system, it builds with "en" file, but when the add-on is built by GitHub action, probably under linux, there is no English help file in the bundle.

Solution

Make "readme" lowercase.

@mltony mltony merged commit 0c4e72a into mltony:master Feb 7, 2025
1 of 2 checks passed
@mltony
Copy link
Owner

mltony commented Feb 7, 2025

Thanks @CyrilleB79!

@mltony
Copy link
Owner

mltony commented Feb 7, 2025

Actually build fails with this PR:
https://github.com/mltony/nvda-sentence-nav/actions/runs/13206478195

@CyrilleB79
Copy link
Collaborator Author

OK. Seems that the workflow is using one (or more) deprecated action.

I have opened #34 to try to fix this, just following the changes made in the add-on template.

@CyrilleB79 CyrilleB79 deleted the case branch February 18, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants