Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SQL file for uninstalling this extension #10

Closed
wants to merge 1 commit into from

Conversation

seancolsen
Copy link

@seancolsen seancolsen commented Sep 15, 2017

This PR makes it possible to uninstall this extension.

Before

  • Attempting to uninstall this extension gives an error that the SQL file is not found.
  • There appears to be no way successfully uninstall it

Caveat: I'm only testing with 4.7. Perhaps somehow this extension does uninstall itself on 4.6 (though I'd be very surprised if that were the case!)

After

  • Uninstalling the extension succeeds.
  • Tables, option values, and message templates are removed

@mlutfy
Copy link
Owner

mlutfy commented Feb 12, 2020

Integrated in recent commits. Thank you!

@mlutfy mlutfy closed this Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants