Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stdev mauricio1802 trying to build in windows using msys2 #2

Open
wants to merge 154 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
154 commits
Select commit Hold shift + click to select a range
22055a6
[config] Create ConfigSection and Option types
mauricio1802 Oct 20, 2019
bdc9084
[config] Implement RegisterSection method for ConfigManager type
mauricio1802 Oct 20, 2019
9fd5d50
[config] Remove ConfigSection type and Add config.go
mauricio1802 Oct 21, 2019
3ba91c2
[config] Add GetValues method to SectionManager
mauricio1802 Oct 21, 2019
7e79f17
[config] Change init and LoadWalletEnvs functions to fit with new config
mauricio1802 Oct 21, 2019
b6cb899
[config] Change Option type to allow multiple levels of groups
mauricio1802 Oct 21, 2019
ccbd1ac
[config] Change SectionManager methods to allow multi level sections
mauricio1802 Oct 21, 2019
4c49f53
[config] Fix methods in skycoin plugin to work with config
mauricio1802 Oct 21, 2019
19c75f1
[config] Create multi platform path to use it as default in wallet so…
mauricio1802 Oct 21, 2019
ce13f91
Merge branch 'fiberDevelop' into stdevMauricio1802_t135_Handle_applic…
mauricio1802 Oct 21, 2019
7bd5f95
[config] Remove debug lines
mauricio1802 Oct 31, 2019
554ca56
[config] Update init function of skycoin package to use new Config ap…
mauricio1802 Oct 31, 2019
530fb7d
Merge branch 'fiberDevelop' into stdevMauricio1802_t135_Handle_applic…
mauricio1802 Nov 20, 2019
3380e8a
[plugin] Move creation and register of skycoin plugin to skycoin/main.go
mauricio1802 Nov 20, 2019
608c4de
[config] Move Register of skycoin plugin to src/coin/skycoin/models/m…
mauricio1802 Nov 20, 2019
256c91c
Merge commit '608c4de' into stdevMauricio1802_t135_Handle_application…
mauricio1802 Nov 20, 2019
6ed4c0b
[plugin] Rewrite LoadWalletEnv function
mauricio1802 Nov 20, 2019
5dce51b
Rename the function `edit` to `setValue` and add a function `getValue…
stdevCrow Nov 21, 2019
262a3ee
Read the default settings with the new functions implemented in the `…
stdevCrow Nov 21, 2019
49dbc06
[config] Add setValue and getValue methods to ConfigManager
mauricio1802 Nov 21, 2019
afcff93
[config] Fix error spliting path
mauricio1802 Nov 21, 2019
31a1bc2
[test] Move model test to src/coin/skycoin/models/main_test.go
mauricio1802 Nov 21, 2019
4501bf3
Merge branch 'fiberDevelop' into stdevMauricio1802_t135_Handle_applic…
mauricio1802 Nov 25, 2019
39361cb
[ui] refs #135 Reimplemented Setting page to use the new model.
hsequeda Dec 3, 2019
d4d2663
Merge branch 'stdevMauricio1802_t135_Handle_application_configuration…
stdevCrow Dec 4, 2019
1f4e0c3
Fix the organization domain: `simelo.tech.org => simelo.tech`
stdevCrow Dec 5, 2019
9a4403b
Properly bind settings with the backend
stdevCrow Dec 5, 2019
95f6e19
Clarify that the wallet path configuration is for local environment only
stdevCrow Dec 5, 2019
998d66f
Remove redundant label `"Local wallet path"`
stdevCrow Dec 5, 2019
2fe7ea1
Remove redundant label `Node Url`
stdevCrow Dec 5, 2019
58239c6
Fix weird `1` pixel offset of the `MenuBar` respect to the top of the…
stdevCrow Dec 5, 2019
565c37e
Replace the `SwitchDelegate` for a simple `Switch` with two `Label`, …
stdevCrow Dec 5, 2019
521974f
Refactor some blocks of code into an independent function.
stdevCrow Dec 5, 2019
428f4ff
Merge branch 'develop' into stdevMauricio1802_t135_Handle_application…
stdevCrow Dec 5, 2019
6d2eb4e
[models] Add getDefaultValue method to ConfigManager
mauricio1802 Dec 9, 2019
cb95855
Merge remote-tracking branch 'simelo_alt/stdevMauricio1802_t135_Handl…
olemis Dec 13, 2019
1c9ce59
[ci] refs #135 - Fix indentation error in Travis script
olemis Dec 13, 2019
7e5cc47
[ci] refs #135 - Clean source before running tests on Travis CI
olemis Dec 13, 2019
b1d1eb3
[util] refs #135 - Replace assert => require in util package cipher t…
olemis Dec 13, 2019
8855886
[ci] refs #135 - Run tests inside Docker container during Travis builds
olemis Dec 13, 2019
e3da088
[ci] refs #135 - Add (missing) therecipe/qt Docker image name in make…
olemis Dec 13, 2019
ba30ce1
[ci] refs #135 - Append default arch name to Docker image name in mak…
olemis Dec 13, 2019
91f5a11
[ci] refs #135 - Add src step in Makefile GOPATH_SRC var
olemis Dec 13, 2019
22e9b9b
Merge remote-tracking branch 'origin/develop' into stdevMauricio1802_…
stdevMac Dec 14, 2019
73f3067
[ci] refs #135 - Run commands inside Docker container with make run-d…
olemis Dec 14, 2019
76f8ed1
[ci] refs #135 - Determine therecipe/qt GOPATH using docker inspect
olemis Dec 14, 2019
2ba642e
[ci] refs #135 - Implement DOCKER_GOPATH_SRC as run-docker target spe…
olemis Dec 14, 2019
975f759
[ci] refs #135 - Append project subpath to Docker GOPATH to mount vol…
olemis Dec 14, 2019
8c6d320
[ci] refs #135 - DOCKER_GOPATH_SRC => DOCKER_GOPATH in make docker-run
olemis Dec 14, 2019
105acea
[ci] refs #135 - Switch to project source folder inside Docker contai…
olemis Dec 15, 2019
9ede320
[ci] refs #135 - For Linux builds run make install-coveralls inside D…
olemis Dec 15, 2019
e44b668
[ci] refs #135 - Use GOPATH (rather than HOME) to run goveralls in ma…
olemis Dec 15, 2019
37995aa
Merge branch 'develop' of https://github.com/fibercrypto/FiberCryptoW…
stdevCrow Dec 15, 2019
80d91c6
Update the `default[...]` properties to get the real default settings…
stdevCrow Dec 15, 2019
ad0cc0b
Get the organization and application's name from the official values …
stdevCrow Dec 15, 2019
2474b6c
[ci] refs #135 - Disable test coverage on Travis CI Linux builds
olemis Dec 15, 2019
df3e176
Merge remote-tracking branch 'simelo_alt/stdevMauricio1802_t135_Handl…
olemis Dec 15, 2019
fc68a84
[ci] refs #284 - Use simelotech/qt-test for make run-docker
olemis Dec 16, 2019
0575265
[ci] refs #135 - Install unzip on Travis Windows builds
olemis Dec 16, 2019
912e3f1
[lint] refs #135 Resolve lint issues
stdevMac Dec 17, 2019
c0e176a
Merge remote-tracking branch 'simelo/stdevMauricio1802_t135_Handle_ap…
stdevMac Dec 17, 2019
fcbe87b
Run qtmoc desktop in windows build before tests
stdevMac Dec 17, 2019
e6e5348
[qt] refs #135 Install qt in windows
stdevMac Dec 17, 2019
ca09880
[ci] refs #135 Add travis_wait to qt download
stdevMac Dec 18, 2019
75ddcf3
Install qt in windows using config script
stdevMac Dec 19, 2019
dcb7200
[ci][win] refs #135 add travis_wait to qt installation
stdevMac Dec 20, 2019
955539c
[qt] refs #135 Run qtsetup propertly
stdevMac Dec 20, 2019
95d95f2
[ci] refs #135 Set travis_wait time to 50 min
stdevMac Dec 20, 2019
d1eecf0
Installing qt before run qtsetup
mauricio1802 Dec 21, 2019
dc7c30a
[ci] refs #135 Test uname_s in travis windows
stdevMac Dec 21, 2019
fd1730d
[ci] refs #135 just run uname_s in travis windows build
stdevMac Dec 21, 2019
0476770
[ci] refs #135 remove # in choco install make in travis
stdevMac Dec 21, 2019
a53ef86
[make][ci] refs #135 Add rule for travis windows installation
stdevMac Dec 21, 2019
639a802
[ci] refs #135 Restore travis and add build on windows directly
stdevMac Dec 21, 2019
998b596
Remove linux and macos stages temporary
mauricio1802 Dec 21, 2019
07f0698
fix error on qt-intall script
mauricio1802 Dec 21, 2019
7e7fc67
Waiting for qt install
mauricio1802 Dec 21, 2019
8d20c03
Wait more time for qt install
mauricio1802 Dec 22, 2019
cb65099
Use script for avoid travis timeout
mauricio1802 Dec 22, 2019
94dd9ba
Add script for avoid travis timeout
mauricio1802 Dec 22, 2019
d196e8e
Update script for install qt
mauricio1802 Dec 22, 2019
4715bdd
Running qtsetup
mauricio1802 Dec 22, 2019
ca45c91
Set environmet variables for qt directory and qt version
mauricio1802 Dec 22, 2019
c33f93c
Installing more qt components
mauricio1802 Dec 22, 2019
f9e4706
Fix error in script for install qt
mauricio1802 Dec 22, 2019
1f866e5
Remove unused qt components because space
mauricio1802 Dec 22, 2019
a475894
Remove more components from install
mauricio1802 Dec 22, 2019
95f0b8b
Install mingw with qt
mauricio1802 Dec 22, 2019
fb51927
Change version of qt to 5.13.0 and showing the output of install
mauricio1802 Dec 22, 2019
9b7bfdd
Add QT5_BASE_DIR variable
mauricio1802 Dec 22, 2019
583713f
Remove logs from qt installation
mauricio1802 Dec 22, 2019
4e78ebb
Show logs of qt installation
mauricio1802 Dec 22, 2019
6d8e4b6
Add components to qt installation
mauricio1802 Dec 22, 2019
39c7f91
Install x64 version of components only in qt installation
mauricio1802 Dec 22, 2019
5a10adc
Add ls commands for know the state of a directory
mauricio1802 Dec 22, 2019
99e7ec1
Remove innecesary empty line
mauricio1802 Dec 22, 2019
6e8447b
Remove component from qt installation and add env var for QT_DIR_QMAKE
mauricio1802 Dec 22, 2019
f0fffaa
[ci] refs #135 Add cache to travis
stdevMac Dec 22, 2019
4381511
Add components fro qtScript to qt installation
mauricio1802 Dec 22, 2019
931111c
Remove qtcreator for reduce space
mauricio1802 Dec 22, 2019
5fe7815
Use another component trying to reduce space
mauricio1802 Dec 22, 2019
f6f2dea
Use df -h to know where the disk is filled
mauricio1802 Dec 22, 2019
d62d79d
trying to use msys2
mauricio1802 Dec 22, 2019
33dc1c2
[make][ci] refs #135 set GO111MODULE=off in windows build
stdevMac Dec 22, 2019
3681e04
Remove unzip install
mauricio1802 Dec 22, 2019
ccb0dc7
Ignoring error on qtsetup
mauricio1802 Dec 22, 2019
3a86160
[ci] remove gzip installation in travis
stdevMac Dec 23, 2019
d1e4cbf
[make] refs #135 remove | true in qtsetup
stdevMac Dec 23, 2019
708116c
[ci] refs #135 Add Appveyor to project
stdevMac Dec 23, 2019
cff79a3
Remove innecesary comands
mauricio1802 Dec 23, 2019
539c44e
Uncomment necesary lines
mauricio1802 Dec 23, 2019
1e5136b
Fix yml
mauricio1802 Dec 23, 2019
1d507e1
Fix yml identation
mauricio1802 Dec 23, 2019
668f4a2
Remove ;s
mauricio1802 Dec 23, 2019
ee00387
Remove make install-deps-Windows
mauricio1802 Dec 23, 2019
12cc6da
Move install commands from before-install to install
mauricio1802 Dec 23, 2019
0d7f777
Install msys2
mauricio1802 Dec 23, 2019
a54606c
Remove conflictive command
mauricio1802 Dec 23, 2019
00db7b4
Using tasklist for detect the process using chocolatey
mauricio1802 Dec 23, 2019
01f8a61
Debugin what process is using chocolatey
mauricio1802 Dec 23, 2019
3a76694
Kill bash.exe
mauricio1802 Dec 23, 2019
baa6b9b
Reviewing log of chocolatey
mauricio1802 Dec 23, 2019
f29a454
Remove commands not used in therecipe/qt doc
mauricio1802 Dec 23, 2019
1ccaa9e
Add options to pacman for not wait input from user
mauricio1802 Dec 23, 2019
879e381
Remove repeated flag
mauricio1802 Dec 23, 2019
c46282e
Using msys2 variable instead shell
mauricio1802 Dec 23, 2019
aba7e90
Using installation for dynamic compiling
mauricio1802 Dec 23, 2019
bc43d01
Using installation for dynamic compiling
mauricio1802 Dec 23, 2019
210e93d
[ci] refs #135 mv appveyor.yml .appveyor.yml
stdevMac Dec 23, 2019
8fce635
Run using bash -c
stdevMac Dec 23, 2019
fe17c2b
[ci] refs #135 Add enviroments var to appveyor
stdevMac Dec 23, 2019
82cfb35
[ci] Remove qt installation in appveyor
stdevMac Dec 23, 2019
372a636
[ci] run ls c:/qt
stdevMac Dec 23, 2019
f40b411
[ci] refs #135 Use mingw as default shell in appveyor
stdevMac Dec 23, 2019
3bb28fb
Set qt_version to 5.13
stdevMac Dec 23, 2019
b2829fb
[make] refs #135 set | true in qtsetup
stdevMac Dec 23, 2019
4e57b1f
[ci] refs Install other qt version
stdevMac Dec 23, 2019
f9ff092
[ci] refs#135 Using mingw shell from qt installation
stdevMac Dec 23, 2019
301f9bd
[ci] Install therecipe/qt using -tags=no_envs
stdevMac Dec 23, 2019
c7f9d78
Update vendor
stdevMac Dec 23, 2019
3fe8367
[changelog] Add address book
stdevMac Dec 23, 2019
15b9703
[ci] Remove ls lines in appveyor
stdevMac Dec 23, 2019
761fcc9
[ci] refs #135 Remove appveyor scripts
stdevMac Dec 23, 2019
4fcf494
Merge remote-tracking branch 'origin/stdevMac_t_Add_appveyor_to_proje…
mauricio1802 Dec 24, 2019
1055068
Trying appveyor
mauricio1802 Dec 24, 2019
2117f31
Merge remote-tracking branch 'simelo/stdevMac_update_vendor_and_chang…
stdevMac Dec 24, 2019
2e68815
Revert "Merge remote-tracking branch 'simelo/stdevMac_update_vendor_a…
stdevMac Dec 24, 2019
b3d7f9c
Merge pull request #260 from simelo/stdevMauricio1802_t135_Handle_app…
olemis Dec 24, 2019
ce82dfa
Change gopath
mauricio1802 Dec 24, 2019
c1ca63d
[ci] refs #135 - Do not make lint on Travis Windows builds
olemis Dec 30, 2019
1b7ab4f
[ci] refs #135 - Disable Windows builds
olemis Dec 30, 2019
b9f9751
Merge remote-tracking branch 'fc/develop' into stdevMauricio1802_Fixi…
olemis Dec 30, 2019
2ca5e85
Merge pull request #292 from simelo/stdevMauricio1802_Fixing_windows_…
stdevMac Dec 30, 2019
2e69367
Merge remote-tracking branch 'fc/develop' into stdevMauricio1802_Tryi…
olemis Dec 30, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions .appveyor.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
version: '{build}'
clone_depth: 1

platform: x64

clone_folder: C:\go\src\github.com\fibercrypto\fibercryptowallet

environment:
GOPATH: C:\go
GOBIN: C:\go\bin
QT5_BASE_DIR: C:/Qt/5.13/msvc2017
QT_DIR: C:/Qt
QT_VERSION: 5.13
QT_QMAKE_DIR: C:/Qt/5.13/mingw73_64/bin

install:
- set "PATH=C:/Qt/5.13/mingw73_64/bin;C:\Windows\System32;C:\Windows;%PATH%"
- set MSYSTEM=MINGW64
- set PATH=%GOPATH%\bin;%GOROOT%\bin;%PATH%
- echo %PATH%
- echo %GOPATH%
- go version
- go env
- choco install make -y
- make install-deps-Windows
- make install-linters
- make install-coveralls

test_script:
- make build-Windows-travis
- make test
- make lint
- make test-cover-travis

build: off
deploy: off
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ htmlcov/
nosetests.xml
coverage.xml
coverage.html
coverage.out
*.cover
.hypothesis/

Expand Down Expand Up @@ -84,3 +85,4 @@ android
rcc_cgo_*.go
darwin


64 changes: 40 additions & 24 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ go:
services:
- docker
go_import_path: github.com/fibercrypto/fibercryptowallet
cache:
directories:
- $GOPATH/src/github.com/therecipe
- $GOPATH/bin
matrix:
include:
- stage: RPI
Expand All @@ -14,52 +18,63 @@ matrix:
- DEFAULT_ARCH=rpi2 make install-docker-deps
- DEFAULT_ARCH=rpi3 make install-docker-deps
- make install-deps-no-envs
- make install-coveralls
script:
- make clean
- DEFAULT_TARGET=rpi1 make build-docker
- DEFAULT_TARGET=rpi2 make build-docker
- DEFAULT_TARGET=rpi3 make build-docker
- make lint
- make test
- make run-docker CMD='make test'
- stage: Android
if: branch = release*$
install:
- DEFAULT_ARCH=android make install-docker-deps
- make install-deps-no-envs
- make install-coveralls
script:
- make clean
- DEFAULT_TARGET=android make build-docker
- DEFAULT_TARGET=android-emulator make build-docker
- make lint
- make test
- make test-cover-travis
- make run-docker CMD='make test'
- make run-docker CMD='make install coveralls ; make test-cover-travis'
- stage: Linux
install:
- make install-docker-deps
- make install-deps-no-envs
- make install-linters
- make install-coveralls
script:
- make clean
- DEFAULT_TARGET=linux make build-docker
- make test
- make lint
- make test-cover-travis
- stage: Windows
os: windows
install:
- choco install make -y
- travis_wait make install-deps-Windows
- make install-linters
- make install-coveralls
script:
- make build
- make test
- make build-icon
- make clean
- make run-docker CMD='make test'
- make lint
- make test-cover-travis
- make run-docker CMD='make install-coveralls ; make test-cover-travis'
# FIXME: Restore Windows builds
# - stage: Windows
# os: windows
# env:
# - QT5_BASE_DIR: C:/Qt/5.13.0/msvc2017
# - QT_DIR: C:/Qt
# - QT_QMAKE_DIR: C:/Qt/5.13.0/mingw73_64/bin
# install:
# - choco install make -y
# - choco install unzip -y
# #- df -h
# #- .travis/install-qt-win.sh
# #- df -h
# #- ls C:/Qt
# #- ls C:/Qt/5.13.0
# #- ls C:/Qt/5.13.0/mingw73_64
# #- ls C:/Qt/5.13.0/mingw73_64/bin
# - travis_wait 50 make install-deps-Windows
# - df -h
# - make install-linters
# - make install-coveralls
# script:
# - make build
# - make test
# - make build-icon
# - make test-cover-travis
- stage: MacOS
os: osx
osx_image: xcode10.2
Expand All @@ -77,8 +92,8 @@ notifications:
email: false
webhooks:
urls:
- https://fathomless-fjord-24024.herokuapp.com/notify
- https://coveralls.io/webhook
- https://fathomless-fjord-24024.herokuapp.com/notify
- https://coveralls.io/webhook

before_deploy:
- export VERSION="$(git describe --tags --exact-match HEAD 2> /dev/null)"
Expand All @@ -97,5 +112,6 @@ deploy:
draft: true
overwrite: true
on:
repo: fibercrypto/fibercryptowallet
repo: fibercrypto/FiberCryptoWallet
tags: true

95 changes: 95 additions & 0 deletions .travis/qt-installer-windows.qs
Original file line number Diff line number Diff line change
@@ -0,0 +1,95 @@


var INSTALL_COMPONENTS = [
"qt.qt5.5130.win64_mingw73",
"qt.qt5.5130.qtscript",
"qt.qt5.5130.qtscript.win64_mingw73",

];

function Controller() {
installer.autoRejectMessageBoxes();
installer.installationFinished.connect(function() {
gui.clickButton(buttons.NextButton);
})
}

Controller.prototype.WelcomePageCallback = function() {
// click delay here because the next button is initially disabled for ~1 second
gui.clickButton(buttons.NextButton, 3000);
}

Controller.prototype.CredentialsPageCallback = function() {
gui.clickButton(buttons.NextButton);
}

Controller.prototype.IntroductionPageCallback = function() {
gui.clickButton(buttons.NextButton);
}

Controller.prototype.DynamicTelemetryPluginFormCallback = function() {
gui.currentPageWidget().TelemetryPluginForm.statisticGroupBox.disableStatisticRadioButton.setChecked(true);
gui.clickButton(buttons.NextButton);

//for(var key in widget.TelemetryPluginForm.statisticGroupBox){
// console.log(key);
//}
}

Controller.prototype.TargetDirectoryPageCallback = function()
{
// Keep default at "C:\Qt".
//gui.currentPageWidget().TargetDirectoryLineEdit.setText("E:\\Qt");
//gui.currentPageWidget().TargetDirectoryLineEdit.setText(installer.value("HomeDir") + "/Qt");
gui.clickButton(buttons.NextButton);
}

Controller.prototype.ComponentSelectionPageCallback = function() {

// https://doc-snapshots.qt.io/qtifw-3.1/noninteractive.html
var page = gui.pageWidgetByObjectName("ComponentSelectionPage");

var archiveCheckBox = gui.findChild(page, "Archive");
var latestCheckBox = gui.findChild(page, "Latest releases");
var fetchButton = gui.findChild(page, "FetchCategoryButton");

archiveCheckBox.click();
latestCheckBox.click();
fetchButton.click();

var widget = gui.currentPageWidget();

widget.deselectAll();

for (var i = 0; i < INSTALL_COMPONENTS.length; i++) {
widget.selectComponent(INSTALL_COMPONENTS[i]);
}

//widget.selectComponent("qt.tools.qtcreator");
//widget.selectComponent("qt.55.qt3d");

gui.clickButton(buttons.NextButton);
}

Controller.prototype.LicenseAgreementPageCallback = function() {
gui.currentPageWidget().AcceptLicenseRadioButton.setChecked(true);
gui.clickButton(buttons.NextButton);
}

Controller.prototype.StartMenuDirectoryPageCallback = function() {
gui.clickButton(buttons.NextButton);
}

Controller.prototype.ReadyForInstallationPageCallback = function()
{
gui.clickButton(buttons.NextButton);
}

Controller.prototype.FinishedPageCallback = function() {
var checkBoxForm = gui.currentPageWidget().LaunchQtCreatorCheckBoxForm;
if (checkBoxForm && checkBoxForm.launchQtCreatorCheckBox) {
checkBoxForm.launchQtCreatorCheckBox.checked = false;
}
gui.clickButton(buttons.FinishButton);
}

27 changes: 10 additions & 17 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,23 +1,20 @@
# Contributing to FiberCrypto projects

We love your input! We want to make contributing to this project as easy and transparent as possible, whether it's:

- Submitting a [bug report](https://github.com/fibercrypto/fibercryptowallet/issues/new?labels=bug&template=bug_report.md)
- Submitting a [bug report](https://github.com/fibercrypto/FiberCryptoWallet/issues/new?labels=bug&template=bug_report.md)
- Discussing the current state of the code on [Blockchain Cuba channel](https://t.me/BlockchainCuba)
- Submitting a [new Github pull request](https://github.com/fibercrypto/fibercryptowallet/pull/new) with a fix
- Proposing new [features requests](https://github.com/fibercrypto/fibercryptowallet/issues/new?labels=feature&template=feature_request.md)
- Submitting a [new Github pull request](https://github.com/fibercrypto/FiberCryptoWallet/pull/new) with a fix
- Proposing new [features requests](https://github.com/fibercrypto/FiberCryptoWallet/issues/new?labels=feature&template=feature_request.md)
- Becoming a maintainer

## We Develop with Github

We use github to host code, to track issues and feature requests, as well as accept pull requests.

## We Use [Github Flow](https://guides.github.com/introduction/flow/index.html), So All Code Changes Happen Through Pull Requests

Pull requests are the best way to propose changes to the codebase (we use [Github Flow](https://guides.github.com/introduction/flow/index.html)). We actively welcome your pull requests:

1. Fork the repo and create your branch from `master`.
- Branch name should follow the pattern `<USER>_t<ISSUE>_<DESC>` e.g. `olemis_t256_readme_badges` for @olemis to submit a patch to fix issue #256 by adding project badges in `README.md` file.
* Branch name should follow the pattern `<USER>_t<ISSUE>_<DESC>` e.g. `olemis_t256_readme_badges` for @olemis to submit a patch to fix issue #256 by adding project badges in `README.md` file.
2. If you've added code that should be tested, add tests.
3. If you've changed APIs, update the documentation.
4. If contributions add a relevant feature, describe changes in CHANGELOG.md
Expand All @@ -27,37 +24,33 @@ Pull requests are the best way to propose changes to the codebase (we use [Githu
8. Issue that pull request!

## Any contributions you make will be under the GPLv3 Software License

In short, when you submit code changes, your submissions are understood to be under the same [GPLv3 License](https://choosealicense.com/licenses/gpl-3.0/) that covers the project. Feel free to contact the maintainers if that's a concern.

## Report bugs using Github's [issues](https://github.com/fibercrypto/fibercryptowallet/issues)

We use GitHub issues to track public bugs. Report a bug by [opening a new issue](https://github.com/fibercrypto/fibercryptowallet/issues/new/choose); it's that easy!
## Report bugs using Github's [issues](https://github.com/fibercrypto/FiberCryptoWallet/issues)
We use GitHub issues to track public bugs. Report a bug by [opening a new issue](https://github.com/fibercrypto/FiberCryptoWallet/issues/new/choose); it's that easy!

## Write bug reports with detail, background, and sample code

[This is an example](http://stackoverflow.com/q/12488905/180626) of a bug report that we think it's not a bad model. Here's [another example from Craig Hockenberry](http://www.openradar.me/11905408), an app developer whom we greatly respect.

**Great Bug Reports** tend to have:

- A quick summary and/or background
- Steps to reproduce
- Be specific!
- Give sample code if you can. [This stackoverflow question](http://stackoverflow.com/q/12488905/180626) includes sample code that _anyone_ with a base R setup can run to reproduce what reporter was seeing
- Give sample code if you can. [This stackoverflow question](http://stackoverflow.com/q/12488905/180626) includes sample code that *anyone* with a base R setup can run to reproduce what reporter was seeing
- What you expected would happen
- What actually happens
- Notes (possibly including why you think this might be happening, or stuff you tried that didn't work)

People _love_ thorough bug reports. I'm not even kidding.
People *love* thorough bug reports. I'm not even kidding.

## Use a Consistent Coding Style

Code style shall respect golang standards and is checked by a number of linters after running `make lint` from the command line.

## License

By contributing, you agree that your contributions will be licensed under its GPLv3 License.

## References

This document was adapted from the open-source contribution guidelines for [Facebook's Draft](https://github.com/facebook/draft-js/blob/a9316a723f9e918afde44dea68b5f9f39b7d9b00/CONTRIBUTING.md).


Loading