-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GetLinesInViewport should consider ignore unchanged. #123
base: master
Are you sure you want to change the base?
GetLinesInViewport should consider ignore unchanged. #123
Conversation
Closes #122 |
@kingcean Could you review? |
@kbeatty-ascensionas Can you share an example text to test with to see the behavior so I can validate? |
What I was seeing is the early breakout in the loop would happen as soon as the first not in the viewport line was encountered. This was exposed by my previous fix that marked zero height lines as NOT being in the view. Ignore the image, it illustrates my previous fix. Not this one. |
@mmanela do you have any comments on this? |
@kingcean can you review? |
This PR is to fix the following issue but sounds it still have a problem. I have updated the implementation by another way and it is in PR #146 .
|
This PR can be closed without merging since the issue has been fixed in |
No description provided.