Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

valid chart report only no owners file #82

Open
wants to merge 52 commits into
base: tests
Choose a base branch
from
Open

valid chart report only no owners file #82

wants to merge 52 commits into from

Conversation

mmulholla
Copy link
Owner

No description provided.

redhat-mercury-bot and others added 30 commits May 18, 2021 09:51
@redhat-mercury-bot
Add new Helm Chart OWNERS file
d43238f
@redhat-mercury-bot
Add new Helm Chart OWNERS file
72fe1dd
@baijum
Merge remote-tracking branch 'upstream/main' into dev
0a6ed91
@baijum
Merge remote-tracking branch 'upstream/main' into dev
37a2709
@baijum
Ignore .DS_Store (#92)
eaddfe8 
Fixes #91
@baijum
Merge remote-tracking branch 'upstream/main' into dev
a9fbdfd
@redhat-mercury-bot @mmulholla
Add new Helm Chart OWNERS file
8d7effe
@redhat-mercury-bot @mmulholla
Add new Helm Chart OWNERS file
8db6ee7
@mmulholla
Merge branch 'dev' of https://github.com/openshift-helm-charts/charts …
d214915 
…into dev
@baijum
Fix the chart index link (#197)
ad5badb
@baijum
Remove hard-coded API server value (#195)
a2de24c 
The API_SERVER GitHub secret should be created with a base64 encoded
string (Warning: That means that's not really a secret -- the value will
be visible in the log)

To generate base64 encoded string for a URL:

  echo -n "https://api.ocpappsvc-osd.zn6c.p1.openshiftapps.com:6443" | base64
@dperaza4dustbit
Adding cluster level rules to our cluster role. (#202)
a6f32cd 
These cluster level rules are the minimum needed for the chart-verifier
to be able to validate the hashicorp/vault chart in our current 4.7 repo.
@baijum
Retry PR merge status check (#205)
4546939
@mmulholla
make sure sanity check finds a match for report only submission (#208)
00179ae
@mmulholla
Don't try to create a release for report only submission (#210)
4511c8d
@dperaza4dustbit
Changing flow to handle sha256 digest for chart package. (#215)
72724c5 
Adding logic to compute digest and compare with digest passed
in report. The digest will be stored at the same level as urls
field.
@mmulholla
fail sanity check if PR includes more that one chart (#223)
8e2bafa
workflows: add redhat and community workflow logic (#224)
3662f59 
* workflows: add redhat and community workflow logic

As part of supporting different vendor types for openshift helm
charts, this adds the github actions for redhat and community
submission. For design details please refer to: docs/workflow-build.md.

Signed-off-by: Allen Bai <[email protected]>

* Update and factor code according to reviews

Signed-off-by: Allen Bai <[email protected]>
@dperaza4dustbit
No need to pass msg to get_vendor_type function (#229)
3d51c1b
@mmulholla
include vendor and semver is file pattern matching (#228)
a913f52
@baijum
Move the version check after report (#201)
2ac469e 
Ref. #200

Currently, chart-testing failure leads to empty value for
certifiedOpenShiftVersions.
There is an open issue about it here:
redhat-certification/chart-verifier#157

This fix will prioritize report verification above the
certifiedOpenShiftVersions.  This way user will see the report error
first.
@mmulholla
revert use of semver in pattern matching (#230)
9c7ecce
@mmulholla
fix regex in pr review (#233)
db8219c
OWNERS: add abai to owners file (openshift-helm-charts#243)
d54372c 
Signed-off-by: Allen Bai <[email protected]>
scripts/verify-report.sh: handle multi-line string with single quotes (…
539849d 
…openshift-helm-charts#242)

This fix handles multi-line reason strings more nicely by removing use
of xargs and concatenating strings spanning multiple lines. Note that
this script will be completely replaced by the incoming report command
of chart-verifier.

Closes: https://issues.redhat.com/browse/HELM-211
Signed-off-by: Allen Bai <[email protected]>
@mmulholla
Update worflow to use new report command
ee543c7
@mmulholla
fix typo 1
bff1857
@mmulholla
fix getReport
1c19da2
@mmulholla
fix function calls
c3d4c64
@mmulholla
fix volume path
d147ab3
@github-actions
Copy link

Thank you for submitting pull request #82 for Helm Chart Certification!

There were one or more errors while building and verifying your pull request.
To see the console output with the error messages, click the "Details"
link next to "CI / Chart Certification" job status towards the end of this page.

[ERROR] The submitted chart has failed certification. Reason(s):

[ERROR] charts/partners/test-org1/chart/OWNERS file does not exist.

Please run the chart-verifier and ensure all mandatory checks pass.

/metadata {"vendor_label": "", "chart_name": ""}

For support, connect with our Technology Partner Success Desk.

@github-actions
Copy link

Thank you for submitting PR #82 for Helm Chart Certification!

An error was found with the Pull Request:
[ERROR] PR should only modify chart related files: charts/partners/test-org1/chart/OWNERS

/metadata {"vendor_label": "", "chart_name": ""}

@mmulholla mmulholla force-pushed the tests branch 4 times, most recently from 354eee8 to fb8bdab Compare July 21, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmulholla @redhat-mercury-bot @baijum @dperaza4dustbit