Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new models and fix sessions #4

Merged
merged 6 commits into from
Nov 1, 2024
Merged

add new models and fix sessions #4

merged 6 commits into from
Nov 1, 2024

Conversation

HRashidi
Copy link
Contributor

@HRashidi HRashidi commented Oct 31, 2024 •
edited
Loading

Changes:

  • Use turbo mode for whisper model
  • Use Qwen/Qwen2-VL-2B-Instruct as captioning model
  • Bumb aana version to 0.6.3.post1
  • Fix sessions

@HRashidi HRashidi requested a review from movchan74 October 31, 2024 08:57
@HRashidi HRashidi linked an issue Oct 31, 2024 that may be closed by this pull request
Update chat_with_video with new models #3
Closed
movchan74
movchan74 requested changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@movchan74 movchan74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but couple things need to be fixed.

Also, run ruff check, there are some issues.

aana_chat_with_video/endpoints/delete_video.py Outdated Show resolved Hide resolved
aana_chat_with_video/endpoints/index_video.py
transcription = sum(transcription_list, AsrTranscription())
segments = sum(segments_list, AsrSegments())
transcription_info = sum(transcription_info_list, AsrTranscriptionInfo())
with get_session() as session:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't keep the session open for the long running tasks. It leads to too many connections to the database. In the long running tasks get session when you actually need to access database. You can combine multiple operations if they are executed in approximately the same time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

aana_chat_with_video/endpoints/load_video_metadata.py Outdated Show resolved Hide resolved
@HRashidi HRashidi requested a review from movchan74 October 31, 2024 12:16
movchan74
movchan74 approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@movchan74 movchan74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@HRashidi HRashidi merged commit a337473 into main Nov 1, 2024
6 checks passed
@HRashidi HRashidi deleted the new_models branch November 1, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@movchan74 movchan74 movchan74 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update chat_with_video with new models
2 participants
@HRashidi @movchan74