Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation fails on MacOS 11.0 #297

Open
sab24 opened this issue Oct 12, 2020 · 5 comments
Open

Compilation fails on MacOS 11.0 #297

sab24 opened this issue Oct 12, 2020 · 5 comments

Comments

@sab24
Copy link

sab24 commented Oct 12, 2020

src/lib/block_if.c:141:1: error: static declaration of 'preadv' follows non-static declaration
preadv(int fd, const struct iovec *iov, int iovcnt, off_t offset)
^
In file included from src/lib/block_if.c:50:
In file included from src/include/xhyve/block_if.h:38:
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/sys/uio.h:103:9: note: previous declaration is here
ssize_t preadv(int, const struct iovec *, int, off_t) __DARWIN_NOCANCEL(preadv) __API_AVAILABLE(macos(11.0), ios(14.0), watchos(7.0), tvos(14.0));
        ^
src/lib/block_if.c:152:1: error: static declaration of 'pwritev' follows non-static declaration
pwritev(int fd, const struct iovec *iov, int iovcnt, off_t offset)
^
In file included from src/lib/block_if.c:50:
In file included from src/include/xhyve/block_if.h:38:
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/sys/uio.h:104:9: note: previous declaration is here
ssize_t pwritev(int, const struct iovec *, int, off_t) __DARWIN_NOCANCEL(pwritev) __API_AVAILABLE(macos(11.0), ios(14.0), watchos(7.0), tvos(14.0));
        ^
2 errors generated.
make: *** [build/lib/block_if.o] Error 1
@sab24
Copy link
Author

sab24 commented Oct 12, 2020

Fixed by removing the static declaration part in the source code of hyperkit in src/lib/block_if.c lines 141 and 152. Unknown whether this causes any runtime issues.

@carlocab
Copy link

carlocab commented Dec 7, 2020

@sab24, is the fix still working for you?

@sab24
Copy link
Author

sab24 commented Dec 7, 2020

@carlocab I don’t have a mac anymore due to Apple malpractices, so I can’t say. In two weeks I can test on another site where there are Apple computers.

@carlocab
Copy link

carlocab commented Dec 7, 2020

I see. Do let me know if you get the chance. Thank you.

@apinske
Copy link

apinske commented Dec 7, 2020

master d8d9fa4 builds on Big Sur, but still fails to run with hv_vm_create HV_ERROR (unspecified error)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants