Rails 5 support #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AJMiller
reviewed
Aug 6, 2018
mockserver-client.gemspec
Outdated
| spec.add_dependency 'activesupport', '~> 4.1' | ||
| spec.add_dependency 'rest-client' | ||
| spec.add_dependency 'json', '>= 1.8' | ||
| spec.add_dependency 'activesupport', '>= 4.1' |
There was a problem hiding this comment.
@chrisbutler I think the build here is failing b/c these dependencies were added twice:
spec.add_dependency 'activesupport', '>= 4.1'
spec.add_dependency 'rest-client', '>= 1.7'
- Locking the json to an old version seems uneccessary - Forcing multi_json and json_pure monkeypatching broke our test suite - removed the json_pure and so far so good
|
@jamesdbloom i made the fix @AJMiller pointed out, and everything is passing now. any chance we can get this merged in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey @jamesdbloom, sorry for creating another PR (#6) but someone here accidentally deleted our fork of your repo
let me know if this PR needs any changes... it would be great to be able to switch back to using a version of your gem instead of a branch of someone else's fork!